larvit/adf-codec
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Read the emphasis, the links and the lone image CommonMark spells #34

Merged
lilleman merged 4 commits from tick-3e into main 2026-08-31 22:33:55 +02:00
Conversation 0 Commits 4 Files Changed 31
+899 -218
lilleman commented 2026-08-31 20:40:36 +02:00
Owner
Copy Link
Copy Source

Milestone 3e: emphasis, links and autolinks in markdownToAdf, with the CommonMark image's node and its two named errors.

The emitter's link destination now escapes an unbalanced parenthesis and the title a quote, so link-destination-parenthesis and link-title-quote move from corpus/unspellable/ to a round-trip pair. unmappable-image joins ConvertErrorCode. Destination and title readers move to markdown/link-syntax.ts beside the spelling they invert.

Milestone 3e: emphasis, links and autolinks in `markdownToAdf`, with the CommonMark image's node and its two named errors. The emitter's link destination now escapes an unbalanced parenthesis and the title a quote, so `link-destination-parenthesis` and `link-title-quote` move from `corpus/unspellable/` to a round-trip pair. `unmappable-image` joins `ConvertErrorCode`. Destination and title readers move to `markdown/link-syntax.ts` beside the spelling they invert.
lilleman added 1 commit 2026-08-31 20:40:36 +02:00
Read the emphasis, the links and the lone image CommonMark spells
CI / gate (push) Successful in 5s
Details
163906dd6a
lilleman marked the pull request as work in progress 2026-08-31 20:40:44 +02:00
lilleman added 1 commit 2026-08-31 21:50:09 +02:00
Part the inline scan into named readers, and share the mark identity both directions read
CI / gate (push) Successful in 6s
Details
2245ab01a9
lilleman added 1 commit 2026-08-31 22:27:41 +02:00
Keep an image's description whole, and the brackets of an empty link text literal
CI / gate (push) Successful in 5s
Details
1c15c7dabe
lilleman added 1 commit 2026-08-31 22:33:24 +02:00
Spell the alt rule in the flavour both directions read
CI / gate (push) Successful in 5s
Details
3349b81b5a
lilleman marked the pull request as ready for review 2026-08-31 22:33:49 +02:00
lilleman merged commit 4ad80e79c5 into main 2026-08-31 22:33:55 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/adf-codec#34
Delete Branch "tick-3e"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?