Make great documentation goal 1.2, and plan the README's reorganisation and the nested-template gaps #33

Open
lilleman wants to merge 966 commits from worktree-todo-relative-dates-exact-counts into main
3 changed files with 3 additions and 7 deletions
Showing only changes of commit 3af4526ef6 - Show all commits
+1 -2
View File
@@ -34,8 +34,7 @@ type Generator struct {
mu sync.Mutex mu sync.Mutex
rand *session rand *session
categories map[string]node categories map[string]node
root folder // the categories as the node a path walks from, owned here so a walk allocates none root folder // the categories as the node a path walks from, owned here so a walk allocates none
set holdSet // one Fake's hold set, owned here so a walk pinning rows keeps them off the heap
records map[node]recordShape records map[node]recordShape
structs map[reflect.Type]structResult structs map[reflect.Type]structResult
} }
+2 -2
View File
@@ -23,8 +23,8 @@ func (f *Generator) Fake(path string) (string, error) {
if err != nil { if err != nil {
return "", fmt.Errorf("fejkdata: %w", err) return "", fmt.Errorf("fejkdata: %w", err)
} }
f.set = holdSet{} var set holdSet
sc := renderScope{set: &f.set} sc := renderScope{set: &set}
f.root.children = f.categories f.root.children = f.categories
n, err := descend(f.rand, &f.root, segments, sc) n, err := descend(f.rand, &f.root, segments, sc)
if err != nil { if err != nil {
-3
View File
@@ -23,9 +23,6 @@ Shape 5.8, Self-sufficiency 5.7), every seat capped by Locality, all nine naming
This round, in order: This round, in order:
- Give `Fake` a local hold set like `FakeRecord`, `RecordTemplate.Fake` and
`FakeStruct`, or state at `Generator.set` why it alone needs one: four seats read the
field's heap claim as contradicted by the other three.
- Spell every panic an earlier check makes unreachable with one greppable phrase: the - Spell every panic an earlier check makes unreachable with one greppable phrase: the
17 say "reached prep unvalidated", "should have been proved", "with no row pinned" 17 say "reached prep unvalidated", "should have been proved", "with no row pinned"
and more, so a user's report greps to nothing. and more, so a user's report greps to nothing.