larvit/fejkdata
3
0
Fork 0
Code Pull Requests 1 Actions Activity

Make great documentation goal 1.2, and plan the README's reorganisation and the nested-template gaps #33

Open
lilleman wants to merge 966 commits from worktree-todo-relative-dates-exact-counts into main
pull from: worktree-todo-relative-dates-exact-counts
merge into: larvit:main
Conversation 0 Commits 966 Files Changed 167
+4 -5
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d50136223a - Show all commits
datatype.go
+4 -5
View File
@@ -147,8 +147,7 @@ func columnItems(n node) (items []*template, nullable bool) {
return items, nullable return items, nullable
} }
// itemKind is how a column item comes by its datatype: none, read from a typed column, or declared. // itemKind is how a column item comes by its datatype, ranked by declaresLess in this order: none, read from a typed column, or declared.
// The kinds are declared from the one that declares least.
type itemKind int type itemKind int
const ( const (
@@ -157,8 +156,8 @@ const (
kindDeclares kindDeclares
) )
func (k itemKind) declaresLess(than itemKind) bool { func declaresLess(a, b itemKind) bool {
return k < than return a < b
} }
func kindOf(t *template) itemKind { func kindOf(t *template) itemKind {
@@ -183,7 +182,7 @@ type itemPair struct {
// the one that declares least, a when both declare alike. // the one that declares least, a when both declare alike.
func disagreement(a *template, da DataType, b *template, db DataType) error { func disagreement(a *template, da DataType, b *template, db DataType) error {
d := itemPair{first: da, second: db, fix: a, other: b, want: db} d := itemPair{first: da, second: db, fix: a, other: b, want: db}
if kindOf(b).declaresLess(kindOf(a)) { if declaresLess(kindOf(b), kindOf(a)) {
d.fix, d.other, d.want = b, a, da d.fix, d.other, d.want = b, a, da
} }
proven := (&valueProof{}).proveColumnItem(d.fix).not[d.want] == "" proven := (&valueProof{}).proveColumnItem(d.fix).not[d.want] == ""