Answer stability round 1: 0 🔴, 3 🟡 (0 misread); pin dashboard heading and branding, fix stale comment

This commit is contained in:
2026-10-31 08:41:59 +01:00
parent 57a1a2899f
commit 437a2e8580
5 changed files with 15 additions and 10 deletions
+2
View File
@@ -65,6 +65,8 @@ test("the dashboard at /dashboard: the instructional starter in the unified shel
assert.match(html, /<aside class="sidebar"/);
// The default is a short instructional starter, not a mock-data list.
assert.match(html, /Starter dashboard/);
assert.match(html, /<h1 class="page-title">Dashboard<\/h1>/); // the topbar heading …
assert.match(html, /<nav class="crumbs"[^>]*>\s*<span>Dashboard<\/span>/); // … and its breadcrumb
assert.match(html, /export default definePlugin/); // shows how to replace it from a plugin
assert.doesNotMatch(html, /<form class="filters"/); // the old mock People list is gone
assert.doesNotMatch(html, /Avery Kline/);
+8 -1
View File
@@ -75,8 +75,15 @@ test("branding logo + default theme flow through when set", () => {
assert.equal(chrome.theme, "dark");
});
test("branding name and sub are translated; an unknown key renders as itself", () => {
const t = (key: string): string => (key === "brand.sub" ? "Undertitel" : key);
const chrome = buildPluginChrome({ menu: { branding: { name: "Acme", sub: "brand.sub" }, override: {} }, t });
assert.equal(chrome.brand.name, "Acme");
assert.equal(chrome.brand.sub, "Undertitel");
assert.equal(buildPluginChrome({ menu: { branding: { name: "Acme" }, override: {} } }).brand.sub, undefined);
});
test("shellUser derives the profile from the real user; anonymous → Guest", () => {
assert.deepEqual(shellUser(null), { email: "", initials: "G", name: "Guest" });
// Real user: name = email local part, email kept, initials = first two letters of the local part.
assert.deepEqual(shellUser({ email: "ada@example.com", id: "u1", permissions: [] }), { email: "ada@example.com", initials: "AD", name: "ada" });
});
+1 -3
View File
@@ -70,8 +70,7 @@ export function buildPluginChrome(opts: ChromeOptions): PageChrome {
};
}
// The User carries no display name (the JWT holds only id/email/permissions), so the profile shows
// the email's local part as the name; anonymous ⇒ "Guest".
// The JWT holds only id/email/permissions, so the profile name is the email's local part.
export function shellUser(user: User | null | undefined, t: Translate = ENGLISH): ShellUser {
if (!user) {
const guest = t("shell.guest");
@@ -81,7 +80,6 @@ export function shellUser(user: User | null | undefined, t: Translate = ENGLISH)
return { email: user.email, initials: (local.slice(0, 2) || "U").toUpperCase(), name: local };
}
// `name`/`sub` pass through `t`, so a catalog key is translated and an operator's own wording renders as written.
function branding(menu: MenuConfig, t: Translate): { logo?: string; name: string; sub?: string; theme?: string } {
const b = menu.branding;
return {