larvit/plainpages
3
0
Fork 0
Code Issues 1 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

Redirect an anonymous hit on /settings to sign-in, not a 500 #191

Merged
lilleman merged 7 commits from item-20 into main 2026-10-31 09:18:48 +01:00
Conversation 0 Commits 7 Files Changed 6
+125 -49
lilleman commented 2026-10-31 09:04:59 +01:00
Owner
Copy Link
Copy Source

An anonymous GET /settings made Kratos answer 401, which flowPage rethrew as a 500. It now redirects to /login with the page as return_to. flowPage is split into flowReturnTo and flowFailure, which takes it under the function limits.

An anonymous GET /settings made Kratos answer 401, which flowPage rethrew as a 500. It now redirects to /login with the page as return_to. flowPage is split into flowReturnTo and flowFailure, which takes it under the function limits.
lilleman added 1 commit 2026-10-31 09:05:00 +01:00
Redirect an anonymous hit on /settings to sign-in with the page as return_to
CI / full-gate (push) Successful in 3m25s
Details
2a4ed30e93
lilleman added 5 commits 2026-10-31 09:11:42 +01:00
Answer security round 1: 0 🔴, 0 🟡 (0 misread); no findings dbd8af08ba
Answer stability round 1: 0 🔴, 2 🟡 (0 misread); pin the 503 on a non-401 failure and the language-only return target 8d1e8be6fc
Answer prose round 1: 0 🔴, 5 🟡 (0 misread); shorten the return-target comment, state why /settings is public, drop the test restatements 943520566e
Answer product-owner round 1: 0 🔴, 0 🟡 (0 misread); one 🟢 declined 5c84cc77fe
File the absolute return_to dropped by a chosen locale as item 39
CI / full-gate (push) Successful in 3m17s
Details
dfd26ada34
lilleman added 1 commit 2026-10-31 09:15:15 +01:00
Remove the shipped item 20 from the plan
CI / full-gate (push) Successful in 3m17s
Details
Mirror / github-mirror (push) Successful in 4s
Details
76995008eb
lilleman merged commit 76995008eb into main 2026-10-31 09:18:48 +01:00
lilleman deleted branch item-20 2026-10-31 09:18:48 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) read-only renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/plainpages#191
Delete Branch "item-20"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?