larvit/plainpages
3
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Build the web image in ci.sh so typecheck and tests run the branch's own deps #35

Merged
lilleman merged 2 commits from ci-build-web-image into main 2026-08-02 15:11:17 +02:00
Conversation 0 Commits 2 Files Changed 2
+10 -2
lilleman commented 2026-08-02 14:37:10 +02:00
Owner
Copy Link
Copy Source

Without --build, the typecheck and unit-test steps reuse whatever web image the runner host last built — the bind mount refreshes the source but node_modules stays baked in from the old lockfile. Dependency bumps were being tested against the previous dependency versions (and only failed later at the E2E image build). Cheap when deps are unchanged: the npm ci layer is cache-keyed on the lockfile.

Without --build, the typecheck and unit-test steps reuse whatever web image the runner host last built — the bind mount refreshes the source but node_modules stays baked in from the old lockfile. Dependency bumps were being tested against the previous dependency versions (and only failed later at the E2E image build). Cheap when deps are unchanged: the npm ci layer is cache-keyed on the lockfile.
lilleman scheduled this pull request to auto merge when all checks succeed 2026-08-02 15:06:15 +02:00
lilleman added 2 commits 2026-08-02 15:06:20 +02:00
Build the web image in ci.sh so typecheck and tests run the branch's own deps 45054db5e6
Make the CI web-image rebuild its own step; note the shared-workspace image-tag race
CI / full-gate (push) Successful in 2m37s
Details
Mirror / github-mirror (push) Successful in 5s
Details
9213e5a0de
lilleman force-pushed ci-build-web-image from 597fb07f9d to 9213e5a0de 2026-08-02 15:06:20 +02:00 Compare
lilleman merged commit 9213e5a0de into main 2026-08-02 15:11:17 +02:00
lilleman deleted branch ci-build-web-image 2026-08-02 15:11:18 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/plainpages#35
Delete Branch "ci-build-web-image"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?