larvit/plainpages
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the Settings cog and its Preferences menu from the sidebar footer #48

Merged
lilleman merged 2 commits from remove-settings-menu into main 2026-08-05 00:28:39 +02:00
Conversation 0 Commits 2 Files Changed 10
+12 -14
lilleman commented 2026-08-05 00:10:32 +02:00
Owner
Copy Link
Copy Source

The sidebar footer's cog opened a menu whose only item, Preferences, went nowhere — and it rendered for signed-out visitors too. Removed, along with its two catalog keys in both locales and the then-unreferenced i-gear icon (views/partials/icons.ejs regenerated from ICON_NAMES).

The footer now carries the profile menu — or Sign in when anonymous — plus the language picker. Kratos' own /settings account flow is unrelated and untouched.

Upgrade note: a deployment that mounted a copy of the shipped en-US.ts as its own locales/<tag>.ts fails boot with unknown key "shell.preferences" — add it to en-US first until those two keys are dropped from the mounted catalog. That is the designed parity check doing its job, not a regression.

The sidebar footer's cog opened a menu whose only item, Preferences, went nowhere — and it rendered for signed-out visitors too. Removed, along with its two catalog keys in both locales and the then-unreferenced `i-gear` icon (`views/partials/icons.ejs` regenerated from `ICON_NAMES`). The footer now carries the profile menu — or Sign in when anonymous — plus the language picker. Kratos' own `/settings` account flow is unrelated and untouched. Upgrade note: a deployment that mounted a copy of the shipped `en-US.ts` as its own `locales/<tag>.ts` fails boot with `unknown key "shell.preferences" — add it to en-US first` until those two keys are dropped from the mounted catalog. That is the designed parity check doing its job, not a regression.
lilleman added 1 commit 2026-08-05 00:10:32 +02:00
Remove the Settings cog and its Preferences menu from the sidebar footer
CI / full-gate (push) Successful in 2m37s
Details
8f7ab55267
lilleman added 1 commit 2026-08-05 00:20:33 +02:00
Narrow the settings-cog test assertions and record the icon-registry contract
CI / full-gate (push) Successful in 2m37s
Details
Mirror / github-mirror (push) Successful in 6s
Details
46548ae758
lilleman marked the pull request as ready for review 2026-08-05 00:23:35 +02:00
lilleman merged commit 46548ae758 into main 2026-08-05 00:28:39 +02:00
lilleman deleted branch remove-settings-menu 2026-08-05 00:28:39 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/plainpages#48
Delete Branch "remove-settings-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?