larvit/plainpages
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Use one verb per action in the English UI: sign in, sign out, create account #49

Merged
lilleman merged 3 commits from uniform-signin-wording into main 2026-08-05 00:57:02 +02:00
Conversation 0 Commits 3 Files Changed 7
+19 -10
lilleman commented 2026-08-05 00:34:08 +02:00
Owner
Copy Link
Copy Source

The landing said "Log in" where the sidebar said "Sign in"; the registration submit said "Sign up" under a "Create account" heading; the expired-logout message said "logout request" where its sign-in twin said "sign-in request". Swedish was already uniform.

A one-verb-per-action assertion in src/i18n/load.test.ts fails on any competing verb in the shipped English catalog (it lives there because locales/ loads every .ts in it as a catalog). Rule recorded in AGENTS.md.

The two e2e specs that clicked "Log in" now scope to #main-content — the anonymous sidebar carries a "Sign in" link of its own.

The landing said "Log in" where the sidebar said "Sign in"; the registration submit said "Sign up" under a "Create account" heading; the expired-logout message said "logout request" where its sign-in twin said "sign-in request". Swedish was already uniform. A one-verb-per-action assertion in `src/i18n/load.test.ts` fails on any competing verb in the shipped English catalog (it lives there because `locales/` loads every `.ts` in it as a catalog). Rule recorded in AGENTS.md. The two e2e specs that clicked "Log in" now scope to `#main-content` — the anonymous sidebar carries a "Sign in" link of its own.
lilleman added 1 commit 2026-08-05 00:34:08 +02:00
Use one verb per action in the English UI: sign in, sign out, create account
CI / full-gate (push) Successful in 2m39s
Details
34b668d49f
lilleman marked the pull request as work in progress 2026-08-05 00:34:19 +02:00
lilleman added 1 commit 2026-08-05 00:43:03 +02:00
Widen the one-verb guard to inflections and drop the last competing English string
CI / full-gate (push) Successful in 2m38s
Details
9a9c63e625
lilleman marked the pull request as ready for review 2026-08-05 00:46:09 +02:00
lilleman added 1 commit 2026-08-05 00:52:06 +02:00
Hold the one-verb rule in AGENTS.md instead of a unit test
CI / full-gate (push) Successful in 2m38s
Details
Mirror / github-mirror (push) Successful in 6s
Details
2b09635ed5
lilleman merged commit 2b09635ed5 into main 2026-08-05 00:57:02 +02:00
lilleman deleted branch uniform-signin-wording 2026-08-05 00:57:02 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/plainpages#49
Delete Branch "uniform-signin-wording"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?