larvit/plainpages
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fail an E2E test on anything the browser logs, in all three engines #56

Merged
lilleman merged 3 commits from e2e-console-guard into main 2026-08-05 11:30:12 +02:00
Conversation 0 Commits 3 Files Changed 12
+151 -26
lilleman commented 2026-08-05 11:00:38 +02:00
Owner
Copy Link
Copy Source

Every Playwright spec now takes its test from e2e-tests/console-guard.ts, which watches every page a test opens: a console error or warning, or an uncaught page error, fails the test that provoked it — at any step.

"All browsers" is literal for the Ory-free suites — visual.spec.ts + language.spec.ts run in Chromium, Firefox and WebKit (the per-test @engines tag is gone). The Ory-backed suites share one backend and stay on Chromium.

Two explicit escapes: the COOP header Chromium drops because the e2e stacks serve plain http over container hostnames, and per-test allowConsole(/…/) — used once, by the 404 spec. Nothing in the app needed fixing; those two were all the sweep found.

src/e2e-console-guard.test.ts locks the wiring in the unit gate, since a spec importing test straight from Playwright would run unwatched and green.

Every Playwright spec now takes its `test` from `e2e-tests/console-guard.ts`, which watches every page a test opens: a console error or warning, or an uncaught page error, fails the test that provoked it — at any step. "All browsers" is literal for the Ory-free suites — `visual.spec.ts` + `language.spec.ts` run in Chromium, Firefox and WebKit (the per-test `@engines` tag is gone). The Ory-backed suites share one backend and stay on Chromium. Two explicit escapes: the COOP header Chromium drops because the e2e stacks serve plain http over container hostnames, and per-test `allowConsole(/…/)` — used once, by the 404 spec. Nothing in the app needed fixing; those two were all the sweep found. `src/e2e-console-guard.test.ts` locks the wiring in the unit gate, since a spec importing `test` straight from Playwright would run unwatched and green.
lilleman added 1 commit 2026-08-05 11:00:38 +02:00
Fail an E2E test on anything the browser logs, in all three engines
CI / full-gate (push) Successful in 2m51s
Details
e808f87fbd
lilleman marked the pull request as work in progress 2026-08-05 11:00:49 +02:00
lilleman added 1 commit 2026-08-05 11:15:35 +02:00
Watch what a beforeAll logs, and record where each message came from
CI / full-gate (push) Successful in 2m48s
Details
690d67728b
lilleman marked the pull request as ready for review 2026-08-05 11:21:01 +02:00
lilleman added 1 commit 2026-08-05 11:21:56 +02:00
Record the unpinned Playwright worker pool as an open decision
CI / full-gate (push) Successful in 2m43s
Details
Mirror / github-mirror (push) Successful in 7s
Details
32154fbbc0
lilleman merged commit 32154fbbc0 into main 2026-08-05 11:30:12 +02:00
lilleman deleted branch e2e-console-guard 2026-08-05 11:30:12 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/plainpages#56
Delete Branch "e2e-console-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?