Fix every defect a phase finds before the next phase runs
This commit is contained in:
@@ -73,3 +73,18 @@ Behaviour of the peer worth knowing that is not our defect.
|
||||
```
|
||||
|
||||
Then set the phase's row in PLAN.md's Status table to `done` or `blocked`, linking the file.
|
||||
|
||||
## Fixing what a phase found
|
||||
|
||||
Every defect a phase records is fixed before the next phase runs — a fix can change behaviour in
|
||||
ways the next experiment must see. One fix per defect class, as its own change:
|
||||
|
||||
1. A worktree on a branch off `origin/typescript` (never `origin/master`, the 0.4.0 code), named
|
||||
for the defect.
|
||||
2. Regression tests in `test/` first, naming the behaviour with the reproducer from the findings;
|
||||
then the implementation; then the decision record in the root `AGENTS.md` where the fix settles
|
||||
a question of the wire or the session's life.
|
||||
3. `/larv-review` on the branch, with the pull request based on `typescript`. When it marks the PR
|
||||
ready, squash-merge it.
|
||||
4. Back in the experiments worktree: fast-forward `typescript`, rerun the experiment that found the
|
||||
defect, delete the workaround its test carried, and note the fix in the findings file.
|
||||
|
||||
Reference in New Issue
Block a user