Drop a false claim about the server's answers, and file what the panel found
Mirror / push (push) Has been cancelled
Test / lint (pull_request) Successful in 20s
Test / test (18) (pull_request) Successful in 32s
Test / test (20) (pull_request) Successful in 34s
Test / test (22) (pull_request) Successful in 33s
Test / test (24) (pull_request) Successful in 28s
Test / test (26) (pull_request) Successful in 36s
Mirror / push (push) Has been cancelled
Test / lint (pull_request) Successful in 20s
Test / test (18) (pull_request) Successful in 32s
Test / test (20) (pull_request) Successful in 34s
Test / test (22) (pull_request) Successful in 33s
Test / test (24) (pull_request) Successful in 28s
Test / test (26) (pull_request) Successful in 36s
This commit is contained in:
+1
-2
@@ -314,8 +314,7 @@ export async function submitSms(deps: SendSmsDeps, sms: SendSmsInput): Promise<S
|
|||||||
|
|
||||||
deps.log.debug('sendSms() - sending', { encoding, segments: segments.length, to: sms.to });
|
deps.log.debug('sendSms() - sending', { encoding, segments: segments.length, to: sms.to });
|
||||||
|
|
||||||
// Segments go out together rather than one-after-a-response: a receiver that waits for every
|
// Segments go out together: a receiver that waits for every segment before answering would otherwise deadlock.
|
||||||
// segment before answering — this library's own server does — would otherwise deadlock.
|
|
||||||
const sent = await Promise.all(segments.map(segment => deps.send({
|
const sent = await Promise.all(segments.map(segment => deps.send({
|
||||||
cmdName: 'submit_sm',
|
cmdName: 'submit_sm',
|
||||||
params: submitSmParams(sms, segment, {
|
params: submitSmParams(sms, segment, {
|
||||||
|
|||||||
@@ -372,6 +372,18 @@ and is also what the panel ranked hardest — two methods, one answer.
|
|||||||
|
|
||||||
### Doc claims this review falsified
|
### Doc claims this review falsified
|
||||||
|
|
||||||
|
- [ ] **Make `LinkGate.isUp()`'s doc true or its state match it.** It says a link attached but not
|
||||||
|
yet bound cannot carry a request, while `up` starts `true`, so the first link and a server
|
||||||
|
session are up before any bind. From the comprehension panel of #25.
|
||||||
|
|
||||||
|
- [ ] **Move `checkSessionOptions()`'s doc comment to what it describes.** It explains why a count
|
||||||
|
below 1 is refused, which is `checkLimits`' job, and says nothing of the function it heads.
|
||||||
|
From the comprehension panel of #25.
|
||||||
|
|
||||||
|
- [ ] **Log why `DlrMerger.expect()` registered no merge.** Ids with no common `<base>-<n>`
|
||||||
|
numbering return silently, the likeliest cause of a `messageDlr` that never fires and the one
|
||||||
|
that leaves no trace. From the comprehension panel of #25.
|
||||||
|
|
||||||
- [ ] **Make "every README example is executed by the suite" true, or stop claiming it.** Goal 10 and
|
- [ ] **Make "every README example is executed by the suite" true, or stop claiming it.** Goal 10 and
|
||||||
the Done table both promise it; `test/readme.test.ts` transcribes the examples by hand and has
|
the Done table both promise it; `test/readme.test.ts` transcribes the examples by hand and has
|
||||||
drifted — 15 fenced `javascript` blocks in the README against 10 tests, and the test named "the
|
drifted — 15 fenced `javascript` blocks in the README against 10 tests, and the test named "the
|
||||||
|
|||||||
Reference in New Issue
Block a user