Read and write every text field on the wire as latin1 #16

Merged

lilleman merged 6 commits from cstring-latin1 into main 2026-09-21 08:28:44 +02:00

Conversation 0 Commits 6 Files Changed 10

+273 -37

lilleman commented 2026-09-21 07:54:27 +02:00

Owner

Copy Link

Copy Source

The codec read C-Octet and Octet Strings with toString('ascii'), which masks bit 7, and wrote them with write(text, 'ascii'), which does not. Both halves are now latin1, and a character past U+00FF is refused instead of truncated to its low octet.

The codec read C-Octet and Octet Strings with `toString('ascii')`, which masks bit 7, and wrote them with `write(text, 'ascii')`, which does not. Both halves are now latin1, and a character past U+00FF is refused instead of truncated to its low octet.

lilleman added 1 commit 2026-09-21 07:54:28 +02:00

Read and write every text field on the wire as latin1 7db242e375

lilleman added 1 commit 2026-09-21 07:59:09 +02:00

Refuse a NULL inside a C-Octet String, which ends the field on the peer c1e0407942

lilleman added 1 commit 2026-09-21 08:08:44 +02:00

Cover the guarded address writers, and cut what the code already says f870b7530f

lilleman added 1 commit 2026-09-21 08:14:09 +02:00

Name the option a refused address came from, and the data a 0.5.0 consumer stored dc690b912f

lilleman added 1 commit 2026-09-21 08:21:01 +02:00

Say what is true for a TLV too, and cover the to half of the check a7eb4923f5

lilleman added 1 commit 2026-09-21 08:25:40 +02:00

Cut the prose the code, the error and the record already carry 36a1c6ea7b

lilleman marked the pull request as ready for review 2026-09-21 08:28:18 +02:00

lilleman merged commit 36a1c6ea7b into main 2026-09-21 08:28:44 +02:00

lilleman deleted branch cstring-latin1 2026-09-21 08:28:44 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

claes.eismar.se lilleman (Lilleman auf Larv) martin.siden

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: larvit/smpp-js#16