larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Refuse a non-finite number where a text field coerces one #18

Merged
lilleman merged 9 commits from worktree-non-finite-text into main 2026-09-21 10:46:52 +02:00
Conversation 0 Commits 9 Files Changed 8
+107 -19
lilleman commented 2026-09-21 10:22:45 +02:00
Owner
Copy Link
Copy Source

wantText() gated on Number.isFinite, so NaN and the infinities no longer reach the wire as text.

wantText() gated on Number.isFinite, so NaN and the infinities no longer reach the wire as text.
lilleman added 1 commit 2026-09-21 10:22:45 +02:00
Refuse a non-finite number where a text field coerces one
Mirror / push (push) Successful in 4s
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 36s
Details
Test / test (20) (pull_request) Successful in 30s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 29s
Details
Test / test (26) (pull_request) Successful in 30s
Details
e7e71ca9bd
lilleman added 1 commit 2026-09-21 10:23:17 +02:00
Say what coercion would put on the wire, in the tense the test now holds
Mirror / push (push) Successful in 5s
Details
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 32s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 37s
Details
Test / test (24) (pull_request) Successful in 37s
Details
Test / test (26) (pull_request) Successful in 29s
Details
63e06856f2
lilleman added 3 commits 2026-09-21 10:29:45 +02:00
Say what is refused, and cover the two wire types the loop missed 93d794e61b
Spell a refused NaN as NaN, where JSON spells it null faa5482c7a
File what tracing the numeric branch turned up
Mirror / push (push) Successful in 5s
Details
Test / lint (pull_request) Successful in 28s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 32s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 36s
Details
bbfd1083b8
lilleman added 1 commit 2026-09-21 10:34:01 +02:00
Tell a consumer how the refusal reaches them, and what it does not cover
Mirror / push (push) Successful in 5s
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 33s
Details
Test / test (26) (pull_request) Successful in 30s
Details
0c4e6000b0
lilleman added 1 commit 2026-09-21 10:35:58 +02:00
Name the goal that outranks, on the number the guard still lets through
Mirror / push (push) Successful in 4s
Details
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 29s
Details
Test / test (24) (pull_request) Successful in 35s
Details
Test / test (26) (pull_request) Successful in 30s
Details
3eb93303c3
lilleman added 1 commit 2026-09-21 10:38:41 +02:00
Take back the surface the compiler cannot guard
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 29s
Details
Test / test (26) (pull_request) Successful in 31s
Details
0620d205d6
lilleman added 1 commit 2026-09-21 10:39:54 +02:00
Correct three claims a reader would have built on
Test / lint (pull_request) Successful in 29s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 29s
Details
Test / test (24) (pull_request) Successful in 29s
Details
Test / test (26) (pull_request) Successful in 30s
Details
Mirror / push (push) Successful in 5s
Details
bdebef849c
lilleman marked the pull request as ready for review 2026-09-21 10:46:47 +02:00
lilleman merged commit bdebef849c into main 2026-09-21 10:46:52 +02:00
lilleman deleted branch worktree-non-finite-text 2026-09-21 10:46:52 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#18
Delete Branch "worktree-non-finite-text"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?