larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Refuse a maxOctets below 1 at startup, like the other limits #24

Merged
lilleman merged 2 commits from range-check-max-octets into main 2026-09-24 00:08:19 +02:00
Conversation 0 Commits 2 Files Changed 5
+16 -7
lilleman commented 2026-09-23 23:48:17 +02:00
Owner
Copy Link
Copy Source

Adds maxOctets to the startup limit check, so server({ maxOctets: 0 }) is refused.

Adds maxOctets to the startup limit check, so server({ maxOctets: 0 }) is refused.
lilleman added 1 commit 2026-09-23 23:48:18 +02:00
Refuse a maxOctets below 1 at startup, like the other limits
Test / lint (pull_request) Successful in 49s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 29s
Details
Test / test (24) (pull_request) Successful in 28s
Details
Test / test (26) (pull_request) Successful in 29s
Details
Mirror / push (push) Successful in 3s
Details
80f77afa0f
lilleman added 1 commit 2026-09-24 00:06:23 +02:00
Pin that maxOctets refuses Infinity, and say refuse where the changelog said drop
Test / lint (pull_request) Successful in 20s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 28s
Details
Test / test (26) (pull_request) Successful in 30s
Details
Mirror / push (push) Successful in 4s
Details
c5ef4c4703
lilleman marked the pull request as ready for review 2026-09-24 00:08:18 +02:00
lilleman merged commit c5ef4c4703 into main 2026-09-24 00:08:19 +02:00
lilleman deleted branch range-check-max-octets 2026-09-24 00:08:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#24
Delete Branch "range-check-max-octets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?