larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Read every occurrence of a repeatable TLV, and drop the unread tlvMap #25

Merged
lilleman merged 11 commits from multiple-tlvs into main 2026-09-25 18:54:29 +02:00
Conversation 0 Commits 11 Files Changed 16
+315 -128
lilleman commented 2026-09-24 00:13:38 +02:00
Owner
Copy Link
Copy Source

The five TLVs SMPP lets repeat parse to an array of every occurrence in wire order; objToPdu() takes an array for them. tlvMap, set and never read, is gone.

The five TLVs SMPP lets repeat parse to an array of every occurrence in wire order; objToPdu() takes an array for them. tlvMap, set and never read, is gone.
lilleman added 1 commit 2026-09-24 00:13:38 +02:00
Read every occurrence of a repeatable TLV, and drop the unread tlvMap
Test / lint (pull_request) Successful in 20s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 28s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 29s
Details
Mirror / push (push) Successful in 4s
Details
Test / test (26) (pull_request) Successful in 30s
Details
10877c9f5f
lilleman added 1 commit 2026-09-24 00:17:20 +02:00
Count and detach a repeatable TLV's occurrences in reassembly, and let only byte or integer tags repeat
Mirror / push (push) Successful in 4s
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 30s
Details
Test / test (22) (pull_request) Successful in 35s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 29s
Details
f6a66336cd
lilleman added 1 commit 2026-09-24 00:18:13 +02:00
Say tlvs.ts reads a TLV stream too
Mirror / push (push) Successful in 6s
Details
Test / lint (pull_request) Successful in 31s
Details
Test / test (18) (pull_request) Successful in 37s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 29s
Details
Test / test (24) (pull_request) Successful in 37s
Details
Test / test (26) (pull_request) Successful in 29s
Details
5cdd3ccdae
lilleman added 1 commit 2026-09-24 00:19:19 +02:00
Count ten goals, and point at where the hard rules live
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 20s
Details
Test / test (18) (pull_request) Successful in 34s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 33s
Details
cbfd6e0fbe
lilleman added 1 commit 2026-09-24 00:19:24 +02:00
Point goal 1 at the defect table where it lives
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 20s
Details
Test / test (18) (pull_request) Successful in 36s
Details
Test / test (20) (pull_request) Successful in 34s
Details
Test / test (24) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 29s
Details
befa648991
lilleman added 1 commit 2026-09-24 00:19:27 +02:00
Link AGENTS.md absolutely, as npm renders the README
Mirror / push (push) Successful in 6s
Details
Test / lint (pull_request) Successful in 29s
Details
Test / test (18) (pull_request) Successful in 35s
Details
Test / test (20) (pull_request) Successful in 29s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 31s
Details
Test / test (26) (pull_request) Successful in 29s
Details
a885913ecb
lilleman added 1 commit 2026-09-24 00:24:36 +02:00
Charge each listed TLV occurrence against the reassembly cap, and file the unknown-tag gap
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 28s
Details
Test / test (18) (pull_request) Successful in 36s
Details
Test / test (20) (pull_request) Successful in 30s
Details
Test / test (22) (pull_request) Successful in 30s
Details
Test / test (24) (pull_request) Successful in 34s
Details
Test / test (26) (pull_request) Successful in 35s
Details
2476684f24
lilleman added 1 commit 2026-09-24 00:24:51 +02:00
Drop a false claim about the server's answers, and file what the panel found
Mirror / push (push) Has been cancelled
Details
Test / lint (pull_request) Successful in 20s
Details
Test / test (18) (pull_request) Successful in 32s
Details
Test / test (20) (pull_request) Successful in 34s
Details
Test / test (22) (pull_request) Successful in 33s
Details
Test / test (24) (pull_request) Successful in 28s
Details
Test / test (26) (pull_request) Successful in 36s
Details
f2ee8aa016
lilleman added 1 commit 2026-09-24 00:27:02 +02:00
Lead the changelog with the read-side break, and show each repeatable TLV's shape
Mirror / push (push) Successful in 4s
Details
Test / lint (pull_request) Successful in 29s
Details
Test / test (20) (pull_request) Successful in 35s
Details
Test / test (18) (pull_request) Successful in 37s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (26) (pull_request) Successful in 28s
Details
11ff349333
lilleman added 1 commit 2026-09-24 00:28:51 +02:00
Have the typed-TLV item prove the changelog's advice compiles
Mirror / push (push) Successful in 6s
Details
Test / lint (pull_request) Successful in 21s
Details
Test / test (18) (pull_request) Successful in 30s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 35s
Details
Test / test (24) (pull_request) Successful in 34s
Details
Test / test (26) (pull_request) Successful in 29s
Details
e83ed1451c
lilleman added 1 commit 2026-09-24 00:31:52 +02:00
Correct the doc claims the prose pass found, and move two decisions into the log
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 28s
Details
Test / test (20) (pull_request) Successful in 34s
Details
Test / test (22) (pull_request) Successful in 34s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 28s
Details
Mirror / push (push) Successful in 7s
Details
01210e734a
lilleman marked the pull request as ready for review 2026-09-25 18:54:25 +02:00
lilleman merged commit 01210e734a into main 2026-09-25 18:54:29 +02:00
lilleman deleted branch multiple-tlvs 2026-09-25 18:54:29 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#25
Delete Branch "multiple-tlvs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?