larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests Actions Activity

Cap the heap unanswered messages hold, and detach them from the chunk they arrived in #28

Merged
lilleman merged 3 commits from held-heap into main 2026-09-25 19:40:57 +02:00
Conversation 0 Commits 3 Files Changed 11
+221 -96
lilleman commented 2026-09-25 19:22:35 +02:00
Owner
Copy Link
Copy Source

Charges each held message by the maxOctets rule and caps the total at 64 MiB per session, beside the 1000-message cap. A single message is copied off the socket chunk before it is held.

Charges each held message by the maxOctets rule and caps the total at 64 MiB per session, beside the 1000-message cap. A single message is copied off the socket chunk before it is held.
lilleman added 1 commit 2026-09-25 19:22:36 +02:00
Cap the heap unanswered messages hold, and detach them from the chunk they arrived in
Test / lint (pull_request) Successful in 25s
Details
Test / test (22) (pull_request) Successful in 32s
Details
Test / test (18) (pull_request) Successful in 33s
Details
Test / test (20) (pull_request) Successful in 32s
Details
Test / test (24) (pull_request) Successful in 31s
Details
Test / test (26) (pull_request) Successful in 31s
Details
Mirror / push (push) Successful in 6s
Details
c3ebd6d6bc
lilleman added 1 commit 2026-09-25 19:28:08 +02:00
Test the held octet accounting and the detach through a session, and file the application-held gap
Test / lint (pull_request) Successful in 25s
Details
Mirror / push (push) Successful in 7s
Details
Test / test (18) (pull_request) Successful in 35s
Details
Test / test (20) (pull_request) Successful in 33s
Details
Test / test (22) (pull_request) Successful in 33s
Details
Test / test (24) (pull_request) Successful in 32s
Details
Test / test (26) (pull_request) Successful in 39s
Details
dba95d9524
lilleman added 1 commit 2026-09-25 19:32:58 +02:00
Split the held-message bounds and the shutdownTimeout fallback into decisions of their own, and drop what code and README say
Test / test (20) (pull_request) Successful in 32s
Details
Test / test (24) (pull_request) Successful in 38s
Details
Mirror / push (push) Successful in 7s
Details
Test / lint (pull_request) Successful in 29s
Details
Test / test (18) (pull_request) Successful in 33s
Details
Test / test (22) (pull_request) Successful in 32s
Details
Test / test (26) (pull_request) Successful in 32s
Details
d8232bcd67
lilleman marked the pull request as ready for review 2026-09-25 19:37:06 +02:00
lilleman closed this pull request 2026-09-25 19:37:13 +02:00
lilleman deleted branch held-heap 2026-09-25 19:37:13 +02:00
lilleman reopened this pull request 2026-09-25 19:37:19 +02:00
lilleman merged commit d8232bcd67 into main 2026-09-25 19:40:57 +02:00
lilleman deleted branch held-heap 2026-09-25 19:40:58 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#28
Delete Branch "held-heap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?