larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Give IncomingRequests a port instead of the Session it drives #33

Merged
lilleman merged 2 commits from incoming-port into main 2026-09-28 00:51:48 +02:00
Conversation 0 Commits 2 Files Changed 5
+130 -67
lilleman commented 2026-09-28 00:38:44 +02:00
Owner
Copy Link
Copy Source

IncomingRequests reaches its session through an IncomingDeps port; a peer's unbind ends the session through peerUnbound(), decided by Session. No public surface change.

IncomingRequests reaches its session through an IncomingDeps port; a peer's unbind ends the session through peerUnbound(), decided by Session. No public surface change.
lilleman added 1 commit 2026-09-28 00:38:45 +02:00
Give IncomingRequests a port instead of the Session it drives
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 37s
Details
Test / test (22) (pull_request) Successful in 32s
Details
Test / test (24) (pull_request) Successful in 34s
Details
Test / test (26) (pull_request) Successful in 37s
Details
Mirror / push (push) Successful in 5s
Details
b2183ea30e
lilleman added 1 commit 2026-09-28 00:43:26 +02:00
Pin only the unbind ordering, type peerUnbound, and drop what the port made stale
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 34s
Details
Test / test (22) (pull_request) Successful in 35s
Details
Test / test (24) (pull_request) Successful in 35s
Details
Test / test (26) (pull_request) Successful in 34s
Details
Mirror / push (push) Successful in 6s
Details
efb59b6cff
lilleman marked the pull request as ready for review 2026-09-28 00:51:36 +02:00
lilleman merged commit efb59b6cff into main 2026-09-28 00:51:48 +02:00
lilleman deleted branch incoming-port 2026-09-28 00:51:48 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#33
Delete Branch "incoming-port"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?