larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Derive the retained octets from ExpiringGroups' weight #36

Merged
lilleman merged 4 commits from reassembly-octets into main 2026-09-28 01:20:22 +02:00
Conversation 0 Commits 4 Files Changed 6
+82 -84
lilleman commented 2026-09-28 01:09:12 +02:00
Owner
Copy Link
Copy Source

Reassembler and HeldMessages stop keeping an octet total by hand: ExpiringGroups weighs each group and evicts past maxWeight.

Reassembler and HeldMessages stop keeping an octet total by hand: ExpiringGroups weighs each group and evicts past maxWeight.
lilleman added 1 commit 2026-09-28 01:09:12 +02:00
Derive the retained octets from ExpiringGroups' weight
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 33s
Details
Test / test (26) (pull_request) Successful in 32s
Details
Mirror / push (push) Successful in 5s
Details
91c155175f
lilleman added 2 commits 2026-09-28 01:13:51 +02:00
Assert a replaced held message leaves its octets with it 7117c91eab
Record a group's weight through weigh() alone
Mirror / push (push) Successful in 5s
Details
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 31s
Details
Test / test (26) (pull_request) Successful in 39s
Details
b1a4201a7d
lilleman added 1 commit 2026-09-28 01:16:07 +02:00
Say what ExpiringGroups leaves to its owners
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 30s
Details
Test / test (26) (pull_request) Successful in 31s
Details
Mirror / push (push) Successful in 5s
Details
acad60c889
lilleman marked the pull request as ready for review 2026-09-28 01:20:14 +02:00
lilleman merged commit acad60c889 into main 2026-09-28 01:20:22 +02:00
lilleman deleted branch reassembly-octets 2026-09-28 01:20:22 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#36
Delete Branch "reassembly-octets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?