larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Size the address arrays' C-Octet Strings through cstring.size() #37

Merged
lilleman merged 2 commits from cstring-arrays into main 2026-09-28 01:29:53 +02:00
Conversation 0 Commits 2 Files Changed 3
+73 -43
lilleman commented 2026-09-28 01:22:57 +02:00
Owner
Copy Link
Copy Source

dest_address_array and unsuccess_sme_array size and advance past each C-Octet String by what cstring.size() returns, so size() refuses what write() refuses.

dest_address_array and unsuccess_sme_array size and advance past each C-Octet String by what cstring.size() returns, so size() refuses what write() refuses.
lilleman added 1 commit 2026-09-28 01:22:57 +02:00
Size the address arrays' C-Octet Strings through cstring.size()
Test / lint (pull_request) Successful in 22s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 32s
Details
Test / test (24) (pull_request) Successful in 31s
Details
Mirror / push (push) Has been cancelled
Details
Test / test (26) (pull_request) Successful in 32s
Details
809acd487e
lilleman marked the pull request as work in progress 2026-09-28 01:23:01 +02:00
lilleman added 1 commit 2026-09-28 01:25:30 +02:00
Branch once on a dest_address's kind when sizing it
Test / lint (pull_request) Successful in 28s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 34s
Details
Test / test (24) (pull_request) Successful in 34s
Details
Test / test (26) (pull_request) Successful in 31s
Details
Mirror / push (push) Successful in 5s
Details
1371137fef
lilleman marked the pull request as ready for review 2026-09-28 01:29:45 +02:00
lilleman merged commit 1371137fef into main 2026-09-28 01:29:53 +02:00
lilleman deleted branch cstring-arrays 2026-09-28 01:29:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#37
Delete Branch "cstring-arrays"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?