larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Split linkDown() into canCarry() and droppedWhileDraining() #38

Merged
lilleman merged 2 commits from link-down into main 2026-09-28 01:43:20 +02:00
Conversation 0 Commits 2 Files Changed 4
+15 -16
lilleman commented 2026-09-28 01:31:39 +02:00
Owner
Copy Link
Copy Source

Session.drain() asked linkDown() two opposite questions; each now has its own predicate.

Session.drain() asked linkDown() two opposite questions; each now has its own predicate.
lilleman added 1 commit 2026-09-28 01:31:39 +02:00
Split linkDown() into canCarry() and droppedWhileDraining()
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 31s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 34s
Details
Test / test (24) (pull_request) Successful in 40s
Details
Test / test (26) (pull_request) Successful in 33s
Details
Mirror / push (push) Waiting to run
Details
8d443bf670
lilleman added 1 commit 2026-09-28 01:34:57 +02:00
Say only what canCarry() and droppedWhileDraining() can know
Test / lint (pull_request) Successful in 23s
Details
Test / test (18) (pull_request) Successful in 32s
Details
Test / test (20) (pull_request) Successful in 31s
Details
Test / test (22) (pull_request) Successful in 31s
Details
Test / test (24) (pull_request) Successful in 31s
Details
Test / test (26) (pull_request) Successful in 31s
Details
Mirror / push (push) Has been cancelled
Details
bfd0ed1b98
lilleman marked the pull request as ready for review 2026-09-28 01:43:16 +02:00
lilleman merged commit bfd0ed1b98 into main 2026-09-28 01:43:20 +02:00
lilleman deleted branch link-down 2026-09-28 01:43:20 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claes.eismar.se lilleman (Lilleman auf Larv) martin.siden
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: larvit/smpp-js#38
Delete Branch "link-down"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?