Let the session own its bind state, written by bound() alone #42

Merged

lilleman merged 11 commits from session-bound into main 2026-09-28 04:37:29 +02:00

Conversation 0 Commits 11 Files Changed 14

+150 -57

lilleman commented 2026-09-28 03:56:16 +02:00

Owner

Copy Link

Copy Source

session.boundAs and session.peerInterfaceVersion become read-only, session.loggedIn is removed, and session.bound(bindType, declaredVersion) is the one way to record a bind — client(), server() and a hand-wired session alike. The state holds through a reconnect's gap.

session.boundAs and session.peerInterfaceVersion become read-only, session.loggedIn is removed, and session.bound(bindType, declaredVersion) is the one way to record a bind — client(), server() and a hand-wired session alike. The state holds through a reconnect's gap.

lilleman added 2 commits 2026-09-28 03:56:17 +02:00

Test that the session owns its bind state and keeps it through a reconnect's gap ebc5db5a00

Let the session own its bind state, written by bound() alone b70f0d6ade

lilleman added 2 commits 2026-09-28 04:01:52 +02:00

Test that bound() refuses a bind type or version it cannot record 3cc38325cc

Refuse a bind bound() cannot record, and document it for a 0.4.0 consumer 2ac72fb3f4

lilleman added 1 commit 2026-09-28 04:05:07 +02:00

Refuse a bind the server cannot record as it refuses one authenticate turns down 9a07f75bdf

lilleman added 2 commits 2026-09-28 04:07:44 +02:00

Test that bound() takes a bind type as a string and names the fix for a wrong one 9eebd42887

Take bound()'s bind type as a string, name the fix in its refusals, and show the ESME's spelling 4bdb1e64b0

lilleman added 1 commit 2026-09-28 04:08:53 +02:00

Spell out the hand-wired ESME's bind, and where a getter-only assignment throws 2142c2e3bb

lilleman added 1 commit 2026-09-28 04:09:41 +02:00

Name strict-mode code as where a getter-only assignment throws 80dc263915

lilleman added 1 commit 2026-09-28 04:11:24 +02:00

Quote a string connectTimeout through quoted() too 3f736ff440

lilleman added 1 commit 2026-09-28 04:11:55 +02:00

Tie the bind-state decision to its goal, and drop what MIGRATION holds e4ff71a86b

lilleman marked the pull request as ready for review 2026-09-28 04:37:28 +02:00

lilleman merged commit e4ff71a86b into main 2026-09-28 04:37:29 +02:00

lilleman deleted branch session-bound 2026-09-28 04:37:29 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

claes.eismar.se lilleman (Lilleman auf Larv) martin.siden

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: larvit/smpp-js#42