larvit/smpp-js
3
0
Fork 0
Code Issues Pull Requests 1 Actions Activity

Let the session own its bind state, written by bound() alone #42

Merged
lilleman merged 11 commits from session-bound into main 2026-09-28 04:37:29 +02:00
Conversation 0 Commits 11 Files Changed 14
+5 -6
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9eebd42887 - Show all commits
test/session.test.ts
+5 -6
View File
@@ -463,12 +463,11 @@ describe('bind', () => {
assert.deepEqual(session.bound('transmitter', undefined), {}); assert.deepEqual(session.bound('transmitter', undefined), {});
assert.equal(session.peerInterfaceVersion, 0x00, 'no declared version is pre-3.4'); assert.equal(session.peerInterfaceVersion, 0x00, 'no declared version is pre-3.4');
// The mistakes an untyped caller makes: the TLV object for its value, a version past int8, a typo. // The likeliest mistakes: the TLV object for its value, a version past int8, the command's name.
for (const [bindType, declared] of [['receiver', { tagValue: 0x34 }], ['receiver', 0x100], ['receiver', 3.4], ['tx', 0x34]]) { assert.match(session.bound('receiver', { tagValue: 0x34 }).err?.message ?? '', /tagValue, or undefined .* got object$/);
const refused: unknown = Reflect.apply(Reflect.get(session, 'bound'), session, [bindType, declared]); assert.ok(session.bound('receiver', 0x100).err);
assert.ok(session.bound('receiver', 3.4).err);
assert.ok(refused && typeof refused === 'object' && 'err' in refused && refused.err instanceof Error); assert.match(session.bound('bind_receiver', 0x34).err?.message ?? '', /without "bind_", got "bind_receiver"$/);
}
assert.equal(session.boundAs, 'transmitter', 'a refused bind leaves the recorded one alone'); assert.equal(session.boundAs, 'transmitter', 'a refused bind leaves the recorded one alone');
assert.equal(session.peerInterfaceVersion, 0x00); assert.equal(session.peerInterfaceVersion, 0x00);