Assert the whole refusal of a save over a teammate's version, and the version read before an unedited save

This commit is contained in:
2026-11-17 03:23:50 +01:00
parent 7e3204a089
commit 0090f87351
+3 -7
View File
@@ -92,6 +92,7 @@ class ConfluencePageTest(ConfluenceCase):
assert isinstance(held, Held), held
self.assertEqual(self.new_store().write(held.text, held.version), held)
self.assertNotIn("PUT", [call[0] for call in self.confluence.calls])
self.assertEqual(self.confluence.calls[-1], ("GET", URL, AUTHORIZATION, None))
self.assertEqual((self.confluence.version, self.confluence.value), (2, value))
def test_refuses_to_save_the_text_a_read_found_where_a_teammate_saved_since(self) -> None:
@@ -100,9 +101,7 @@ class ConfluencePageTest(ConfluenceCase):
assert isinstance(held, Held), held
self.confluence.teammate_saves("- their decision\n")
written = self.new_store().write(held.text, held.version)
assert isinstance(written, Failure), written
self.assertIn("someone saved", written.reason)
self.assertIn("ask the human", written.reason)
self.assertEqual(written, Failure(f"someone saved {PAGE.spelling} since the loop read version 2 of it, so the loop didn't write it: never overwrite their edit, but ask the human what to do (Confluence holds version 3)"))
self.assertNotIn("PUT", [call[0] for call in self.confluence.calls])
self.assertEqual(self.new_store().read(), "- their decision\n")
@@ -124,10 +123,7 @@ class ConfluencePageTest(ConfluenceCase):
assert isinstance(held, Held), held
self.confluence.teammate_saves("their edit\n")
written = self.new_store().write("my edit\n", held.version)
assert isinstance(written, Failure), written
self.assertIn("someone saved", written.reason)
self.assertIn("ask the human", written.reason)
self.assertIn(PAGE.spelling, written.reason)
self.assertEqual(written, Failure(f"someone saved {PAGE.spelling} since the loop read version 1 of it, so the loop didn't write it: never overwrite their edit, but ask the human what to do (PUT /wiki/api/v2/pages/{PAGE.page_id} answered 409: Version must be incremented on update. Current version is: 2)"))
self.assertEqual(self.new_store().read(), "their edit\n")
def test_keeps_no_version_itself_so_a_read_never_moves_the_version_a_write_names(self) -> None: