Check each new decision against the project's principles, in rules/decisions.md and larv-review
This commit is contained in:
@@ -1553,3 +1553,20 @@ Read most (opens and searches):
|
||||
- `bin/chunk_preflight/main.py` 3
|
||||
- `bin/release_plan/release_standing.py` 3
|
||||
- `CHANGELOG.md` 2
|
||||
|
||||
## Reading cost, chunk fe37d406ce5e, finished 2026-11-11T14:48:44Z
|
||||
|
||||
98857 new input tokens before the first commit.
|
||||
|
||||
Read most (opens and searches):
|
||||
|
||||
- `bin/rule_hook/test_rule_hook.py` 9
|
||||
- `bin/rule_hook/main.py` 6
|
||||
- `todo.md` 5
|
||||
- `bin/rule_hook/rules.py` 3
|
||||
- `skills/larv-review/SKILL.md` 3
|
||||
- `.gitignore` 2
|
||||
- `README.md` 2
|
||||
- `bin/rule_hook/call.py` 2
|
||||
- `docs/decisions.md` 2
|
||||
- `AGENTS.md` 1
|
||||
|
||||
@@ -9,3 +9,5 @@ paths:
|
||||
**The decision log has one home: `docs/decisions.md`**. A title states the whole decision in one line: what holds at the commit it ships in, in words a reader finds in the code or the plan. `AGENTS.md` lists every title, so a session works by the decisions without loading their background. The entry holds the background: its date, who made it, the reasoning, and the premise it rests on ("valid while X") so it can expire honestly when that premise dies.
|
||||
|
||||
**Every decision links to a goal or a technical principle.** An entry names the goal it serves or the technical principle under `~/.claude/principles/` it applies; one that can do neither is a missing goal, and an entry already in the repo with neither behind it is a finding. Propose the goal, never a reason of your own — `~/.claude/CLAUDE.md` → "Working loop", "Ask, don't guess" says how. An entry working against a goal or a technical principle stands only while it names the `todo.md` item that ends it.
|
||||
|
||||
**Check each new decision against the project's principles.** A principle, listed in the project's `AGENTS.md` under `## Principles`, states one rule that several decisions apply. Each time a decision is recorded, ask three things: does a principle already cover it, does it break one, does it suggest a new one? A decision a principle covers adds no title to `AGENTS.md`. A break, a new principle, or a change to one is the human's: ask, unless the evidence is overwhelming, and leave the principles as they are until the human answers. A break questions both sides: either the principle or the decision is wrong.
|
||||
|
||||
@@ -106,6 +106,7 @@ A fix meets every row it fits. Prose has no row, so a comment or doc edit inside
|
||||
|
||||
- **Outside the chunk.** A finding outside the chunk's change, whatever its pass or severity, is scored and filed in `todo.md` per `~/.claude/rules/todo-items.md`. A 🔴 is marked `defect`. A 🟡 against a file under `~/.claude/principles/` is marked `principle`, its detail naming the principle, where no other reason fits. One under the bar and not exempt is named in the summary with its score. A verified security HIGH is handled per "Security". In the release review the whole project is the chunk's change, so nothing lies outside it; "Release review" → "Findings" says which of its findings are filed.
|
||||
- **Goal or decision.** A fix that would change a goal, or a `docs/decisions.md` entry the repo held before the chunk began, is asked; no user reachable → filed, marked `question`, the goal or decision left as is.
|
||||
- **New decision.** Each decision a fix or an answer records in `docs/decisions.md` is checked against the project's principles per `~/.claude/rules/decisions.md` → "Check each new decision against the project's principles", before the commit that records it.
|
||||
- **🔴.** A 🔴 is fixed, or shown factually wrong, and what disproved it recorded per `~/.claude/skills/larv-review/standards/comments.md` → "Where a choice goes": in a comment at the code the finding concerns, or in `docs/decisions.md` when it concerns more than one place. Never declined.
|
||||
- **🟡.** A 🟡 is fixed, shown factually wrong like a 🔴, or declined. Decline one only where the reason is sound, consistent with the goals and the technical principles, and confidence is very high; the decline and its reason are recorded the same way. A reason neither speaks to is a gap in the goals: fix the finding, or ask per `~/.claude/CLAUDE.md` → "Working loop", "Ask, don't guess"; no user reachable → fix. Never drop one silently, and never decline one for convenience or the size of the fix.
|
||||
- **🟢 and ❓.** A 🟢 or ❓ is fixed, answered, declined in the summary with its reason, or filed. Answer one where the code, a test, a goal or a decision the repo held before the chunk began settles it, and quote what in the summary. A ❓ only the user can answer is asked; no user reachable → filed, marked `question`.
|
||||
|
||||
Reference in New Issue
Block a user