Answer stability round 2: 0 🔴, 0 🟡 (0 misread); say only that a closed epic is closed
CI / tests (pull_request) Successful in 4m52s
CI / tests (pull_request) Successful in 4m52s
This commit is contained in:
@@ -83,7 +83,7 @@ def closed(epic: str, store: EpicStore, stdin: typing.TextIO) -> str | Failure:
|
||||
return Failure(f"cannot close the epic {epic}: {issues.reason}")
|
||||
already = store.closed()
|
||||
if already:
|
||||
return Failure(f"cannot close the epic {epic}: {already.reason if isinstance(already, Failure) else 'it is closed already, so its summary is posted'}")
|
||||
return Failure(f"cannot close the epic {epic}: {already.reason if isinstance(already, Failure) else 'it is closed already'}")
|
||||
if waiting := still_open(issues):
|
||||
return Failure(f"cannot close the epic {epic}: {listed(waiting, 'and')} {'is' if len(waiting) == 1 else 'are'} open")
|
||||
if lacking := unreviewed(issues):
|
||||
|
||||
@@ -90,7 +90,7 @@ class ClosingTheEpic(DoEpicTest):
|
||||
self.store.done = True
|
||||
code, _, err = self.close()
|
||||
self.assertEqual(code, 1)
|
||||
self.assertIn("cannot close the epic ABC-12: it is closed already, so its summary is posted\n", err)
|
||||
self.assertIn("cannot close the epic ABC-12: it is closed already\n", err)
|
||||
self.assertEqual(self.store.comments, {})
|
||||
|
||||
def test_says_why_it_cannot_tell_whether_the_epic_is_closed(self) -> None:
|
||||
|
||||
Reference in New Issue
Block a user