Record the comprehension check: PR #475 at 52da15e means 6.38 overall, run late for item 301; refresh floor item 300
CI / tests (pull_request) Successful in 2m3s

This commit was merged in pull request #476.
This commit is contained in:
2026-11-11 13:56:30 +01:00
parent 52da15ea2b
commit 329f0fd3a0
2 changed files with 67 additions and 9 deletions
+50
View File
@@ -3478,3 +3478,53 @@ Inherited architect, would restructure first:
- Locality: `bin/loop_claude/routing.py:93` `unfinished_route`: routing logic spreads over about eight places, so a new trigger touches five files in three packages
- Shape: `bin/rule_hook/rules.py:25` `RULES`: rules sit inline in one module while five others have a module each
- Navigation: `bin/` README.md:116 "bin/": 56 entries in one flat list, the worst fan-out level
## 2026-11-11T12:55:06Z, PR #475 at 52da15e
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|---|---|---|---|---|---|
| Junior A | 7 | 5.5 | 6 | 6 | 6 |
| Mid A | 7.5 | 6 | 6.5 | 6.5 | 6.5 |
| Maintainability senior | 7 | 6 | 6.5 | 6 | 6.5 |
| Inherited architect | 7 | 6.5 | 6 | 7 | 6.5 |
| Mean | 7.13 | 6.00 | 6.25 | 6.38 | 6.38 |
Junior A, hardest first:
- Locality, Shape: `bin/loop_claude/routing.py:93` `unfinished_route`: the floor, the escalation cap, the escalation mark, the unfinished count and the taken-in E + I are held at once
- Locality: `bin/loop_claude/cycle/judge.py:211` `quotes_checked`: the judge's contract is split over prose constants, schema descriptions and post-hoc checks that change a verdict's type
- Locality: `bin/loop_claude/cycle/run.py:146` `rule`: archive order carries meaning across `run_cycle` and `loop/close.py:18` `closed_cycle`
- Shape: `bin/release_plan/release_standing.py:145` `next_release`: tag, changelog, before-first-release and renamed branches meet in the `is_earliest` expression
- Shape: `bin/release_plan/ranking.py:56` `rank`: `OLD_SHAPE` and `SHAPE` forks run through nearly every function
- Self-sufficiency: `bin/loop_claude/cycle/prompts.py:59` `review_launches`: the worker's prompt is built from about ten conditional sentence builders
- Locality: `skills/larv-review/SKILL.md:76` "Round cap": the cap is enforced in four units in two places
Mid A, hardest first:
- Locality, Shape: `bin/loop_claude/routing.py:93` `unfinished_route`: five things applied in a fixed order across about six helpers; the reason for the floor and cap sits in the decision log
- Locality: `bin/loop_claude/cycle/run.py:146` `rule`: the order of ruling, rejection and step-up archive writes is stated piecemeal
- Shape: `bin/release_plan/ranking.py:315` `weight_of`: old-shape branches double the module, and the constants are magic until rules/todo-items.md is open
- Shape: `bin/release_plan/release_standing.py:145` `next_release`: a three-way boolean on line 167 with no comment for the `None` and `nothing_cut` case
- Locality: `bin/rule_hook/repeat_read.py:119` `shown_lines`: rebuilds which lines are in the agent's context from transcript entries
- Locality: `bin/loop_claude/cycle/judge.py:211` `quotes_checked`: half of the judge's rules are English constants edited in step with Python
- Locality: `bin/loop_claude/cycle/prompts.py:119` `escalation`: about 20 sentence builders restate the routing logic
Maintainability senior, hardest first:
- Shape, Locality: `bin/release_plan/release_standing.py:145` `next_release`: four fallbacks held at once, and `is_earliest` took three reads
- Locality: `bin/loop_claude/routing.py:93` `unfinished_route`: the escalation mark's meaning lives in `escalation_mark.py`, which has to stay open beside it
- Locality: `bin/loop_claude/cycle/judge.py:211` `quotes_checked`: a bad quote silently changes the verdict's type
- Shape: `bin/release_plan/ranking.py:304` `score`: every path forks on `SHAPE` versus `OLD_SHAPE`
- Locality: `bin/rule_hook/reviewer_rung.py:40` `skill_breaches`: three cases rest on assumptions made in another function
- Locality: `bin/loop_claude/cycle/run.py:146` `rule`: order-dependent archive writes that nothing enforces
- Shape: `bin/review_rules/comprehension_history.py:127` `entries`: a line-by-line parser that tolerates two legacy formats
- Self-sufficiency: `skills/larv-review/SKILL.md:76` "Round cap": dense cross-referencing rules, with the enforcing code in other modules
Inherited architect, would restructure first:
- Navigation, Shape: `README.md:116` `bin/`: 55 entries at one level, about 31 packages, the worst fan-out level
- Locality: `bin/larv_review/reviewer_header.py:49` `unanswered_round`: the round cap counts answer commits, so a worker that relaunches without committing gets the same round number, and the rule is split over SKILL.md and three modules
- Locality, Shape: `bin/loop_claude/routing.py:93` `unfinished_route`: seven counters and limits across five files, with field names frozen by the reload handover
- Locality: `bin/chunk_pr/main.py:42` `forge`: the forge helpers live in `chunk_preflight` and `deploy_release`, so a second forge needs edits in four packages
- Shape: `bin/records/__init__.py:1` `records`: one name for three concepts, as `cut` and `Plan` also name several
- Locality: `bin/loop_claude/cycle/run.py:86` `archived`: the archive helpers that `loop/close.py` imports sit in the cycle runner
+17 -9
View File
@@ -27,7 +27,7 @@
| 273 | 0.9.0 | | decision | **Re-tune the E + I steps of `REVIEW_STEPS` for 6 to 8 once 10 finished chunks have scored an E + I of 6 or more, from how well E + I orders their review rounds and 🔴 findings.** | 1 | 2 | 2 | 3 | 2 | 1.1 by 2, 1.4 by 3 | 2.3 |
| 268 | 0.9.0 | | | **End a run whose release is ready to cut with a notice on loop-claude's terminal, in place of an interrupt that waits for an answer.** | 2 | 2 | 3 | 5 | 3 | 1 by 5 | 2.2 |
| 171 | 0.9.0 | | decision | **Group the routing figures' review rounds by the reviewers' rung as well as the worker's, so a call blames a rung only for rounds its own reviews raised.** | 3 | 2 | 2 | 5 | 4 | 1.2 by 3, 1.4 by 3 | 2.0 |
| 300 | 0.9.0 | | owner | **Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 13d1550 scored Locality 5.50, Shape 6.00, Self-sufficiency 6.38 and Overall 6.00.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 2.0 |
| 300 | 0.9.0 | | owner | **Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 52da15e scored Locality 6.00, Shape 6.25, Self-sufficiency 6.38 and Overall 6.38.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 2.0 |
| 264 | 0.9.0 | | | **Report the comprehension seats and the escalated subagents as subagent types of their own in `routing-figures.md`, with their dollars.** | 2 | 2 | 1 | 3 | 3 | 1.4 by 5 | 2.0 |
| 149 | 0.9.0 | | decision | **Fill each release by priority up to a capacity it states, in place of the bar, and move what does not fit to a later release.** | 4 | 2 | 3 | 7 | 5 | 1.1 by 7 | 1.8 |
| 165 | 0.9.0 | | | **Make this repo's tests assert the facts a prompt or help text carries in place of its sentences, and drop the tests that scan source or assert a constant.** | 3 | 2 | 1 | 4 | 5 | 1.1 by 4, 1.4 by 3 | 1.8 |
@@ -157,23 +157,31 @@ Releases are the human's, and `CLAUDE.md` → "Working loop" already ends the lo
Raised by the goals audit of PR #296. `bin/routing_figures/calls.py` groups a chunk's review rounds by the rung its worker started on, and calls for a routing change when a lower rung took more of them. Since PR #296 the reviewers may run above the worker's rung, on the one their item's E + I picks, and no figure groups rounds by it, though the archived worker line names the E + I it follows from. A cheap worker on an item of high E + I gets stronger reviewers, who may raise more rounds, and a call could then blame the worker's rung for them: an interrupt of lilleman that settles nothing (goal 1.2).
### 300. Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 13d1550 scored Locality 5.50, Shape 6.00, Self-sufficiency 6.38 and Overall 6.00.
### 300. Restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first: today the comprehension floor run at 52da15e scored Locality 6.00, Shape 6.25, Self-sufficiency 6.38 and Overall 6.38.
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`. The lowest mean is Locality, 5.50. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the run of PR #475 at 52da15e. The lowest mean is Locality, 6.00. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
Aim: one ambitious refactor of the areas below, sized so every mean reaches 7.0 on the chunk's own scoring run. Where a place is already easier to read when the chunk starts, drop it.
Places the seats named, hardest first (`larv-review places`):
- Locality, Shape: `bin/loop_claude/routing.py:93` `unfinished_route`: the floor rung, the escalation mark, the unfinished count and the cap are held at once, and the logic spreads over about eight places in three packages.
- Locality, Shape: `bin/loop_claude/routing.py:93` `unfinished_route`: the floor rung, the escalation cap, the escalation mark, the unfinished count and the taken-in E + I are held at once, across about six helpers in five files. The mark's meaning lives in `escalation_mark.py`, and the reason for the floor and the cap sits in the decision log.
- Locality, Shape: `bin/release_plan/release_standing.py:145` `next_release`: the tag, changelog, before-first-release and renamed branches meet in the `is_earliest` expression, which took a senior three reads. Nothing comments the `None` and `nothing_cut` case.
- Locality: `bin/loop_claude/cycle/judge.py:211` `quotes_checked`: the judge's contract is split over prose constants, schema descriptions and checks after the fact. A bad quote silently changes the verdict's type.
- Locality, Shape: `bin/loop_claude/cycle/run.py:146` `rule`, with `loop/close.py:18` `closed_cycle`: the order of the ruling, rejection and step-up archive writes carries meaning, and nothing enforces it. Four near-identical archive helpers, `run.py:86` `archived` among them, sit in the cycle runner though `loop/close.py` imports them, and `run_cycle` replaces the route partway through its loop.
- Locality, Self-sufficiency: `bin/larv_review/reviewer_header.py:49` `unanswered_round` and `skills/larv-review/SKILL.md:76` "Round cap": the cap counts answer commits, so a worker that relaunches without committing gets the same round number. The cap is enforced in four units, split over SKILL.md and three modules.
- Locality, Shape: `bin/larv_review/plan.py:66` `plan_reasons`: a merge-base commit enters the parameter that item 296's chunk renamed `ref`, eight failure branches mix git reads, file reads and logic, and `after` means the checkout's text and then its items.
- Locality: `bin/larv_review/owed.py:37` `shortfall`: the one-run-or-two rule is keyed on the wording `EMPTIED_WORDS` that plan.py builds and SKILL.md quotes; `scoring_runs` defines a scoring run differently from `Entry.scored`. Give the scoring-run logic one module, and have the number of runs owed come from a value, not from a sentence.
- Locality: `bin/loop_claude/cycle/judge.py:211` `quotes_checked`: a verdict is rewritten four times, half the behaviour in prompt prose and half in code.
- Locality: `bin/larv_review/owed.py:37` `shortfall`: the one-run-or-two rule is keyed on the wording `EMPTIED_WORDS` that plan.py builds and SKILL.md quotes, and `scoring_runs` defines a scoring run differently from `Entry.scored`. Give the scoring-run logic one module, and have the number of runs owed come from a value, not from a sentence.
- Locality: `bin/chunk_pr/main.py:42` `forge`: the forge helpers live in `chunk_preflight` and `deploy_release`, so a second forge needs edits in four packages.
- Locality: `bin/rule_hook/reviewer_rung.py:40` `skill_breaches`: three cases rest on assumptions made in another function.
- Locality: `bin/rule_hook/repeat_read.py:119` `shown_lines`: it rebuilds from transcript entries which lines are in the agent's context.
- Locality: `bin/model_routing/route.py:88` `route_of`: a route has two serializations, a flat archive line and a nested handover.
- Shape: `bin/release_plan/ranking.py:56` `rank` and `:304` `score`: nearly every function forks on the table's two shapes; item 156 removes the old one.
- Shape: `bin/loop_claude/cycle/run.py:59` `run_cycle`: four near-identical archive helpers and a route replaced partway through the loop.
- Self-sufficiency, Locality: `bin/loop_claude/cycle/prompts.py:59` `review_launches` and `:119` `escalation`: the worker's prompt is built from about 20 conditional sentence builders, which restate the routing logic.
- Shape: `bin/release_plan/ranking.py:56` `rank`, `:304` `score` and `:315` `weight_of`: nearly every function forks on `SHAPE` versus `OLD_SHAPE`, which doubles the module; item 156 removes the old shape. The constants read as magic until `rules/todo-items.md` is open.
- Shape: `bin/review_rules/comprehension_history.py:127` `entries`: a line-by-line parser that tolerates two legacy formats.
- Shape: `bin/records/__init__.py:1` `records`: one name for three concepts, as `cut` and `Plan` also name several.
- Shape: `bin/rule_hook/rules.py:25` `RULES`: rules sit inline in one module while five others have a module each.
- Navigation: `README.md:116` `bin/`: 56 entries in one flat list, the worst fan-out level.
- Navigation, Shape: `README.md:116` `bin/`: about 55 entries in one flat list, some 31 of them packages, the worst fan-out level.
- Self-sufficiency: `skills/larv-review/SKILL.md:147` "Scoring run": dense rule prose with many cross-references; three sections rebuild one rule.
Scored L 4 because the refactor touches several components that hold known defects, E 2 because review and a manual check see a regression, I 3 because every session runs these tools. The chunk runs a scoring run, since its tagline names the comprehension floor.