Answer prose round 1: 0 🔴, 9 🟡 (0 misread); reword the skill's Reports, Relaunch, Places and Bash lines, put the history paragraph after record-scoring, reword reviewer-header's help, break the and-chains, and name the merge base in the changelog; product-owner's help-order note rides along

This commit was merged in pull request #449.
This commit is contained in:
2026-11-09 02:36:23 +01:00
parent eebd88f232
commit 455efdc0d1
4 changed files with 22 additions and 20 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
## Unreleased
- `larv-review reviewer-header <pass> [--rerun]` writes the branch diff and the places into the chunk's review folder and prints the header of a reviewer's prompt: the pass, its next round, the PR, the worktree, the branch, the base and the paths of the report, the diff and the places.
- `larv-review reviewer-header <pass> [--rerun]` writes the branch diff and the places into the chunk's review folder and prints the header of a reviewer's prompt: the pass, its next round, the PR, the worktree, the branch, the merge base of HEAD and the default branch, and the paths of the report, the diff and the places.
- `chunk-pr open|ready|merge` opens a chunk's pull request as a draft, marks it ready and merges it, with `gh` or `tea` as the remote needs. It merges only with `--gate-passed`, by the first merge method the repository allows. `larv-review` and `CLAUDE.md` now tell workers to use it.
- `score-outcomes` now gives, where most of the chunks it counts for L hold no 🔴, the share of chunks with a 🔴 at each L in place of L's rank correlation by 🔴 findings.
- `todo-item add` now files an item in `todo.md` with one command. It takes `Next ID` as the item's ID, raises `Next ID`, writes the row and the detail it reads from stdin, and ranks the file.
+1 -1
View File
@@ -97,7 +97,7 @@ Install puts only `loop-claude` and `loop-inbox` on `PATH`; call the others by t
- `chunk-preflight` finds the mechanical facts a chunk starts from, and with `--worktree` makes its worktree; `loop-claude` runs it with `--worktree` before it routes each chunk, and `chunk-preflight --help` lists the facts.
- `deploy-release [--cut] [<checkout>]` moves `~/.claude`, or the checkout named, to the newest release, as Update says; with `--cut`, run in the development clone, it first cuts the next release, as Release says.
- `judge-replay <model>` replays loop-claude's judge on archived verdicts of the projects run on the model, and prints the lowest rung that, like each rung above it, returns them; `judge-replay --help` states the replay.
- `larv-review <command>` holds larv-review's mechanical rules: the chunk's review folder, the paired ruling's base and vote count, each pass's round count, the scoring run's trigger, and the comprehension history's format and latest places, and its count of how often seats agree, and writes each reviewer's prompt header; `larv-review --help` states them.
- `larv-review <command>` holds larv-review's mechanical rules: the chunk's review folder, the paired ruling's base and vote count, each pass's round count, the scoring run's trigger; the comprehension history's format, its latest places and its count of how often seats agree; and each reviewer's prompt header. `larv-review --help` states them.
- `loop-claude <task>` runs a project's next chunk cycle after cycle; `loop-claude --help` states its contract.
- `loop-inbox` shows the interrupts of every loop-claude on the machine, oldest first, takes each one's answer, `/talk` included, and lists every running loop with the `todo.md` items its chunk takes; `loop-inbox --help` states how.
- `metric-bench [history]` benches cheap static metrics of a project's Python against the places its comprehension history names as hardest; `metric-bench --help` states the metrics and the scores.
+15 -13
View File
@@ -1,4 +1,4 @@
"""Hold larv-review's mechanical rules: the chunk's review folder, the paired ruling's base and vote count, each pass's rounds, the scoring run's trigger, and the comprehension history's format and latest places, and its count of how often seats agree, and the header of each reviewer's prompt.
"""Hold larv-review's mechanical rules: the chunk's review folder, the paired ruling's base and vote count, each pass's rounds, the scoring run's trigger; the comprehension history's format, its latest places and its count of how often seats agree; and the header of each reviewer's prompt.
usage: larv-review review-folder | ruling-base | round-count | needs-scoring-run [<item ID>...] | record-ruling <votes file> | record-scoring <scores file> [<item ID>...] | places | agreement | reviewer-header <pass> [--rerun]
@@ -80,6 +80,10 @@ refresh that item instead. Then it ranks the checkout's todo.md as rank_todo.py
overall sets the weight of code health, the goal every project shares, and exits 1 where
rank_todo.py would, with the run recorded.
record-ruling and record-scoring append each entry to the history, created when missing, under a
heading of the current UTC time and the seats file's first line. Each commit that line names must be
in the checkout. Each exits 1 when the history already holds an entry on what that line reads.
places prints the places seats found hard since the newest scored commit: the places of each scoring
run on it, and,
in each later ruling, each place opening with a dimension, or Overall, that its seat voted worse.
@@ -92,18 +96,16 @@ and the inherited architect vote alike overall in a paired ruling more often tha
same way in a pair. It prints both counts. It opens `Unchecked:` until the history holds {pairs} such
pairs and one paired ruling, then `Assumption holds:` or `Assumption fails:`, and exits 0 each time.
reviewer-header takes a pass that an agent under agents/ reviews, as round-count names it, and
prints the header of the prompt that launches its reviewer in the pass's next round: the pass and
round, the branch's open pull request at its pushed head, the worktree and branch, the merge base of
HEAD and the default branch, and the paths of the reviewer's report, the branch diff and, for
architecture and stability, the places. It writes the diff, from that base to HEAD, into the chunk's
review folder as branch-<short HEAD>.diff, and what places prints as places.md. --rerun names the
report of a relaunch one rung up, in the same round, and the report that asked for it. It exits 1
when the pass takes no more rounds.
Each entry is appended to the history, created when missing, under a heading of the current UTC
time and the seats file's first line. Each commit that line names must be in the checkout. It exits 1
when the history already holds an entry on what that line reads.
reviewer-header takes the name of a pass that an agent under agents/ reviews, spelled as round-count
prints it, such as stability. It prints the header of the prompt that launches the pass's reviewer
in its next round: the pass and round, the branch's open pull request at its pushed head, the
worktree and branch, the merge base of HEAD and the default branch, and the paths of the reviewer's
report, the branch diff and, for architecture and stability, the places. It writes the diff, from
that base to HEAD, into the chunk's review folder as branch-<short HEAD>.diff, and writes what
places prints into places.md; a file whose text is unchanged is left as it is. With --rerun, the
header names the report of a relaunch one rung up, in the same round, and the report that asked for
it. It exits 1 when the pass takes no more rounds, or, with --rerun, when the report that asked is
missing.
Exit 1, saying why, on unknown arguments, an unknown item ID, a seats file it cannot read or that
breaks the shape above, a todo.md that fails rank_todo.py after record-scoring records a run, or
+5 -5
View File
@@ -55,11 +55,11 @@ A comment is prose, not code, in any file, and so is a docstring. A change to co
2. Principles, with Full scan or Security, and Overrides.
3. Stability, Product-owner and Prose.
Give a reviewer without Bash `git ls-files`'s output in its prompt: some harnesses grant it Read alone, and it reads the branch diff from the file its header names.
Give a reviewer without Bash `git ls-files`'s output in its prompt, since some harnesses grant it Read alone.
`~/.claude/bin/larv-review` holds this section's mechanical rules: the chunk's review folder, the round count, the paired ruling's base and vote count, the scoring run's trigger, and the history's format and latest places, and its count of how often seats agree, and the header of each reviewer's prompt. Run it in the chunk's worktree; `~/.claude/bin/larv-review --help` states each rule. On exit 1, repair what its message names and run it again; when you cannot, ask the user.
`~/.claude/bin/larv-review` holds this section's mechanical rules: the chunk's review folder, the round count, the paired ruling's base and vote count, the scoring run's trigger; the history's format, its latest places and its count of how often seats agree; and the header of each reviewer's prompt. Run it in the chunk's worktree; `~/.claude/bin/larv-review --help` states each rule. On exit 1, repair what its message names and run it again; when you cannot, ask the user.
**Reports.** Open each prompt to an agent under `~/.claude/agents/` with what `~/.claude/bin/larv-review reviewer-header <pass>` prints in the chunk's worktree, then add the change summary. The header names the pass, its next round, the PR, the worktree, the branch and the base. It also names three files in the chunk's review folder, which it makes: the reviewer's full report, `<pass>-round-<n>.md`; the branch diff it writes there; and, for architecture and stability, the places it writes there. For a relaunch one rung up, add `--rerun`: the report becomes `<pass>-round-<n>-rerun.md`, and the header names the report that asked. Before you answer a 🔴 or 🟡, read its entry: Grep the report for the finding's place, with the lines after it, rather than Read the whole report. rule-hook refuses a reviewer's Edit and MultiEdit, and any Write outside `~/.local/state/larv-review/`. Keep the folder after the merge: `review-replay` replays a round from the reports its prompt names.
**Reports.** Run `~/.claude/bin/larv-review reviewer-header <pass>` in the chunk's worktree, and open each prompt to an agent under `~/.claude/agents/` with what it prints; then say in a few lines what the change does and which files it touches. The command makes the chunk's review folder and writes the branch diff into it. The header names that diff and the reviewer's full report, `<pass>-round-<n>.md`, in the folder, and for architecture and stability the places too. For a relaunch one rung up, add `--rerun`: the report becomes `<pass>-round-<n>-rerun.md`, and the header names the report that asked. Before you answer a 🔴 or 🟡, read its entry: Grep the report for the finding's place, with the lines after it, rather than Read the whole report. rule-hook refuses a reviewer's Edit and MultiEdit, and any Write outside `~/.local/state/larv-review/`. Keep the folder after the merge: `review-replay` replays a round from the reports its prompt names.
**Precedent, then ask** — for the full scan:
@@ -99,7 +99,7 @@ A fix meets every row it fits. Prose has no row, so a comment or doc edit inside
**Rung up.** A reviewer rules the work below standard when its report holds systems-architect's BLOCK or a finding against `standards/quality.md`. A comprehension seat does when `record-ruling` counts one of its votes as worse.
- **Ask.** Such a reviewer or seat may end its report asking for a rerun one rung up. Relaunch it only on the rung loop-claude's prompt names for it; where the prompt names none, the report stands.
- **Relaunch.** Relaunch a reviewer on that rung with the same prompt, except for its header, made with `--rerun` per "Reports"; its report stands in place of that one, in the same round. Relaunch a seat with the same prompt alone; its line replaces the one that asked in the votes file, before `record-ruling` runs. A relaunch cannot ask again.
- **Relaunch.** Relaunch a reviewer on that rung with the same prompt, except for its header, made with `--rerun` per "Reports"; its report stands in place of the report that asked, in the same round. Relaunch a seat with the same prompt alone; its line replaces the one that asked in the votes file, before `record-ruling` runs. A relaunch cannot ask again.
- **Escalate.** A below-standard ruling in the report that stands is escalation trigger 4 in `~/.claude/CLAUDE.md` → "Working with the codebase", unless the fix changes only prose: the worker then fixes it on its own rung.
**Findings.** A reviewer rates each finding 🔴 must fix, 🟡 should fix, 🟢 nit, ❓ question, or 🔀 escalation naming the reviewer whose concern it is.
@@ -153,7 +153,7 @@ The comprehension check records how hard the project is for its contributor to r
**Record.** `docs/comprehension-history.md` keeps every paired ruling and scoring run, which `larv-review` appends; never edit one. Commit what it appends, with the `todo.md` that `record-scoring` re-ranks in one commit titled `Record the comprehension check: …`, push it, and wait for the forge's checks (§4 step 4), not for an auto-review; it re-enters no pass. Resolve a merge conflict in the file by putting the default branch's entries first. Put each ruling with its base and votes, and each run's five scores, in the summary.
**Places.** Give systems-architect and stability-reviewer what `~/.claude/bin/larv-review places` prints: the places seats found hard since the newest scored commit. Their header names the file that holds it. Ask each to report, as a 🟡, each of those places the change touches without making it easier to read, matching a place by its path and the function or section it names, since its line may have moved. Fix such a 🟡, or say in the PR summary why not; that reason settles it in place of a decline's record.
**Places.** The header of systems-architect and stability-reviewer names `places.md`, which holds what `~/.claude/bin/larv-review places` prints: the places seats found hard since the newest scored commit. Ask each to report, as a 🟡, each of those places the change touches without making it easier to read, matching a place by its path and the function or section it names, since its line may have moved. Fix such a 🟡, or say in the PR summary why not; that reason settles it in place of a decline's record.
**Suspended.** A decision in the project's `docs/decisions.md`, held before the chunk began, may name plan items to ship without a comprehension check. A named item counts as `todo.md` worded it before the chunk began. The decision must name the later plan item whose chunk ends the suspension with a comprehension check. A chunk may ship named items only with each other. Such a chunk skips the comprehension check, and its summary cites the decision. A chunk due a scoring run runs it, even when every item it ships is named.