Keep a filed finding from being raised again, and order the re-entry rule

This commit is contained in:
2026-09-28 19:46:43 +02:00
parent c5a28c2cce
commit 470ca6b2f0
2 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
Words: `~/.claude/CLAUDE.md` → "Vocabulary".
A reviewer reads and reports; it edits nothing. Read `docs/decisions.md` first: a finding it declines is not raised again.
A reviewer reads and reports; it edits nothing. Read `docs/decisions.md` and `todo.md` first: a finding declined in the one or filed in the other is not raised again.
## Severity
+4 -4
View File
@@ -15,7 +15,7 @@ Words: `~/.claude/CLAUDE.md` → "Vocabulary". Findings, for every reviewer: ~/.
- Not a git repo → say so and stop.
- Someone else's PR, or the user asked for opinions only → one stability run, report its findings, done.
- **Premises first**, per `~/.claude/CLAUDE.md` → "Working loop". Missing, or too vague to settle a decision → this chunk cannot be judged: stop, say so, and write them with the user as the chunk instead. That chunk's whole review is the human's approval, since a reviewer's findings on it could only be declined by citing the goals it exists to write; a later change to a goal takes the full review. Only what that section lets through without them reaches review.
- **Premises first**, per `~/.claude/CLAUDE.md` → "Working loop". Missing, or too vague to settle a decision → this chunk cannot be judged: stop, say so, and write them with the user as the chunk instead. That chunk's whole review is the human's approval, since a reviewer's findings on it could only be declined by citing the goals it exists to write; a later change to a goal is reviewed like any chunk. Only what that section lets through without them reaches review.
- Issue trackers are project-specific — the project's own docs say whether it has one. When it does and the work has a ticket, follow that tracker's conventions for assignment and status.
## 2. Ship the branch (idempotent — skip whatever already exists)
@@ -29,7 +29,7 @@ Follow `~/.claude/CLAUDE.md` → "Git, commits, and PRs". Never commit to the de
| Architecture, then the comprehension floor | systems-architect, then the `comprehension-panel` scoring run | carries an architectural decision: a new, restructured or moved component, module, service or boundary; a new dependency or first use of an infrastructure pattern (queue, cron, cache, websocket, …); a new or changed external contract (routes, request/response shapes, events, webhooks, published file formats); a schema change beyond an additive column; more than ~400 non-generated lines of code or ~5 modules |
| Security | `/security-review` | changes code or config; a fix, only where it opens an untrusted-input boundary or touches authn/authz, secrets or crypto |
| Full security scan | the `claude-security` plugin (`/claude-security` → "Scan changes") | touches authn/authz, secrets or crypto, opens an untrusted-input boundary, or adds an external surface |
| Stability | stability-reviewer | changes code, config or tests; a fix, only where it changes what the code or its tests do |
| Stability | stability-reviewer | changes code, config or tests; a fix, only where it changes behaviour: what the code or its tests do |
| Product-owner | product-owner-reviewer | changes an external surface: API, CLI, UI, error or deprecation text a consumer reads, README and docs an outside reader lands on |
| Prose | you, and a fresh-context agent | every chunk; a fix, where it touches prose |
@@ -37,7 +37,7 @@ A comment is prose, not code. Passes run in this order: line-level polish on cod
**Record, then ask**, for the architecture pass and the full scan: where the repo holds the decision this change executes — a decision-log entry, or a planning item crediting the pass — the pass is done: skip it and cite the record. A change that *departs* from the record is unreviewed however thorough the record is. Fired with no record behind it → ask the user with the evidence and your recommendation; no user reachable → run it.
**Re-entry.** A fix is a change the passes have not seen. Classify it by the widest thing it touches — the first row whose trigger it fires, none sending it straight to §4 — and run forward from that row through §4, each later pass only where its trigger fires too. The pass whose findings it answers runs again as well, per the findings document's rounds.
**Re-entry.** A fix is a change the passes have not seen. The pass whose findings it answers runs again, per the findings document's rounds; beyond it, classify the fix by the widest thing it touches — the first row whose trigger it fires, none sending it to §4 — and run forward from that row through §4, each later pass only where its trigger fires too.
### Architecture
@@ -84,7 +84,7 @@ The bar is `~/.claude/CLAUDE.md` → "Comments and documentation"; per paragraph
2. Watch the forge's checks until every one passes. A red check is a finding; its fix re-enters per §3.
3. No CI configured → the gate is local tests only; note it in the summary.
4. Everything green → mark the PR ready, dropping any `WIP:`/`Draft:` title prefix.
5. **External auto-reviewer**, when the repo has one — its config file (`.coderabbit.yaml` and the like), or its comments on earlier PRs; none → skip it, say so. Marking the PR ready is what summons it. Wait up to **10 minutes** for its first review, checking about once a minute; nothing by then → note it in the summary and carry on, never waiting twice. Its findings follow the findings document like any reviewer's, and its reviews count against the round cap as a pass's runs do. Each later return here, after a fix re-entered per §3, waits up to **5 minutes** for its re-review of the new commit.
5. **External auto-reviewer**, when the repo has one — its config file (`.coderabbit.yaml` and the like), or its comments on earlier PRs; none → skip it, say so. Marking the PR ready is what summons it. Wait up to **10 minutes** for its first review, checking about once a minute; nothing by then → note it in the summary and carry on, never waiting twice. Its findings follow the findings document like any reviewer's, and its reviews count against the round cap as a pass's runs do. Once it has reviewed, each later return here, after a fix re-entered per §3, waits up to **5 minutes** for its re-review of the new commit.
## 5. Goal alignment, then merge