Answer stability round 2: 1 🔴, 0 🟡 (0 misread); the fake's blocker check types, and the imports in order
CI / tests (pull_request) Successful in 4m27s

This commit is contained in:
Lilleman
2026-11-19 17:06:29 +01:00
parent b7d7a1f1ea
commit 62b4825cea
5 changed files with 7 additions and 6 deletions
+3 -2
View File
@@ -24,9 +24,10 @@ class MemoryEpic:
return Failure(self.fails)
if refused := unfit(summary, labels):
return refused
if parent != self.epic_key and parent not in {issue.key for issue in self.issues if issue.parent == self.epic_key}:
children = {issue.key for issue in self.issues if issue.parent == self.epic_key}
if parent != self.epic_key and parent not in children:
return no_parent(self.epic_key, parent)
if blocked_by is not None and blocked_by not in {issue.key for issue in self.read()}:
if blocked_by is not None and blocked_by not in {issue.key for issue in self.issues if issue.parent == self.epic_key or issue.parent in children}:
return no_blocker(self.epic_key, blocked_by)
key = f"{self.epic_key.rpartition('-')[0]}-{len(self.issues) + 100}"
self.issues.append(EpicIssue(key, summary, detail.strip(), tuple(sorted(labels)), None, "To Do", False, parent, blockers=(blocked_by,) if blocked_by else (), by_loop=True))
+1 -1
View File
@@ -5,11 +5,11 @@ import typing
from adf_codec.convert import adfs_to_markdown, markdown_to_adf, Refused
from atlassian.client import basic_auth, Http, jira_json, ToAdf, ToMarkdown
from plan_store.jira_epic import BLOCKS, FILED_BY, ISSUE_TYPE, PROPERTY, scores
from atlassian.jira import DONE, entry_of, finishing_transition, ISSUE_KEY, MAX_PAGES, move_refusal, PERHAPS_FILED, PERHAPS_MOVED, project_of, rank_refusal, searched, SHAPE, status_category, unshaped
from project_config.settings import Epic, Finish, JIRA_FINISH_STATUS, JIRA_FINISH_TRANSITION
from do_epic.backend.protocol import EpicIssue, no_blocker, no_child, no_parent, no_words, unfit, unfit_label
from failure import Failure
from plan_store.jira_epic import BLOCKS, FILED_BY, ISSUE_TYPE, PROPERTY, scores
FIELDS = ["summary", "description", "labels", "assignee", "status", "parent", "issuelinks"]
# How many child issues one search for sub-tasks names, which keeps its JQL well inside the length Jira takes.
+1 -1
View File
@@ -4,11 +4,11 @@ import unittest
sys.path.insert(0, str(pathlib.Path(__file__).resolve().parents[2]))
from do_epic.backend.protocol import EpicIssue, no_blocker
from do_epic.backend.contract import EpicStoreContract
from failure import Failure
from plan_store import jira_epic
from do_epic.backend.fake import MemoryEpic
from do_epic.backend.protocol import EpicIssue, no_blocker
class MemoryEpicContract(EpicStoreContract, unittest.TestCase):
+1 -1
View File
@@ -8,8 +8,8 @@ import pathlib
import typing
from do_epic.repo_pick import CLAUDE_LABEL, HUMAN_LABEL, of_label, REPO_PREFIX, REVIEW_LABEL
from do_epic.epic_record import EpicRecord
from do_epic.backend.protocol import EpicIssue, EpicStore
from do_epic.epic_record import EpicRecord
from failure import Failure
from text_files.markdown_text import listed
from text_files.piped_text import piped
+1 -1
View File
@@ -12,8 +12,8 @@ from do_epic.test_main import DESCRIPTION, DoEpicTest
from do_epic.epic_record import EpicRecord
from failure import Failure
from loop_effects.doubles import FakeEffects
from record_store.held import Held
from do_epic import findings, main
from record_store.held import Held
from do_epic.backend.fake import MemoryEpic
from loop_state.paths import paths_from