File item 517: let a subagent in another repo's worktree run the security pass
CI / tests (pull_request) Successful in 6m2s

This commit is contained in:
Lilleman
2026-11-22 17:51:54 +01:00
parent 51e5054a5c
commit 7aa2957241
+17 -1
View File
@@ -6,7 +6,7 @@
`Bar = 0.1`
`Next ID = 517`
`Next ID = 518`
## Items
@@ -87,6 +87,7 @@
| 266 | 0.23.0 | | | **Move the chunks archived under the key `home/lilleman/.claude` to the key `claude-config`, so the routing figures and `score-outcomes` count this repo's chunks as one project.** | 3 | 2 | 2 | 5 | 3 | 1.4 by 3 | 1.0 |
| 339 | 0.23.0 | | | **Lower the reading cost of the files a chunk reads most before its first commit.** | 2 | 2 | 1 | 3 | 3 | 1.4 by 3 | 1.0 |
| 341 | 0.23.0 | | | **Hand each worker's claude a lower Read limit through `CLAUDE_CODE_FILE_READ_MAX_OUTPUT_TOKENS`, kept only where replays of the archived review rounds find what two unchanged replays find.** | 2 | 2 | 3 | 5 | 3 | 1.4 by 3 | 1.0 |
| 517 | 0.23.0 | | | **Let a subagent that ships a chunk in a worktree of another repo run larv-review's security pass on that worktree's diff.** | 2 | 2 | 3 | 5 | 3 | 1.5 by 3 | 1.0 |
| 513 | 0.23.0 | | | **Refuse `nothing`, `no one` and `nobody` after a verb or a preposition in everything Claude writes: files, commit messages, pull requests and Jira text before they are written, and chat replies by sending them back to be reworded.** | 3 | 2 | 3 | 6 | 5 | 1.1 by 4 | 0.9 |
| 181 | 0.23.0 | | principle | **Have the test of a quoted answer's step-up assert the stepped rung's facts as literals, not through `prompts.rungs_held`.** | 1 | 1 | 1 | 1 | 1 | 1.1 by 2 | 0.9 |
| 193 | 0.23.0 | | | **Narrow `numbered`'s mark to `Mark` by a typed lookup in place of `typing.cast`, so a mark added to the regex but not the lookup fails at run time, and one added to the lookup but not `Mark` fails mypy.** | 1 | 1 | 3 | 3 | 1 | 1.1 by 2 | 0.9 |
@@ -611,6 +612,21 @@ Touches:
- `bin/agent_cycle/test_run.py`: `Cycles` (small)
- `bin/loop_claude/loop/test_usage.py`: `HelpLimits` (small)
### 517. Let a subagent that ships a chunk in a worktree of another repo run larv-review's security pass on that worktree's diff.
On 2026-11-22, eleven subagents each shipped a chunk in a worktree of a different repo. Every one of them hit the same problem at the security pass:
- `/security-review` reads the diff of the session's working directory, which a subagent inherits from the main session.
- A `cd` inside the subagent doesn't reach the skill.
- `EnterWorktree` refuses a worktree of another repo.
So each subagent stopped before opening its pull request, and the main session had to `cd` into each worktree and launch the security subagent from there. Every chunk waited on the main session. Some subagents also reviewed by hand, which larv-review forbids.
Make one of these work, and test it with a subagent in a worktree of another repo:
- `EnterWorktree`, or a launch option, sets a subagent's working directory to any worktree path;
- or larv-review's security launch names the worktree and the base ref, and the skill reviews `git diff <base>...HEAD` there.
Then larv-review §3 → "Security" says how a subagent in another repo's worktree runs the pass.
### 513. Refuse `nothing`, `no one` and `nobody` after a verb or a preposition in everything Claude writes: files, commit messages, pull requests and Jira text before they are written, and chat replies by sending them back to be reworded.
The human can't stand the `changes nothing` form, and `CLAUDE.md` → "Prose" bans it, yet it still slips through: on 2026-11-22 a draft goal read "a repo that calls the action and changes nothing keeps working". A prose rule only works when the model notices, so move the check into tools, which catch it every time.