Answer prose round 1: 0 🔴, 3 🟡 (0 misread); reword the approval docstring and tell the worker it awaited a person's merge
CI / tests (pull_request) Successful in 4m31s

This commit is contained in:
Lilleman
2026-11-19 18:07:54 +01:00
parent 22654a5e05
commit 7e141eaa1e
2 changed files with 3 additions and 3 deletions
+2 -2
View File
@@ -12,8 +12,8 @@ WAIT_SECONDS = 90 * 60
PARKS = "CHUNK_PR_PARKS"
def awaited(forge: Forge, wait_for_approval: bool, by_human: bool = False) -> bool | Failure:
"""Whether merge waits for an approval: the project config's `wait-for-approval`, and never where a person merges the pull request (by_human), who sees its approval themselves. chunk-pr reads approvals on GitHub only, so a Gitea project that sets it fails, and merge never skips an approval the config requires."""
def awaited(forge: Forge, wait_for_approval: bool, by_human: bool) -> bool | Failure:
"""Whether merge waits for an approval. Never where a person merges the pull request (by_human): that person reads its approvals. Otherwise as the project config's `wait-for-approval` says; chunk-pr reads approvals on GitHub only, so a Gitea project that sets it fails, and the chunk never merges past an approval the config requires."""
if by_human:
return False
if wait_for_approval and forge != "gh":
+1 -1
View File
@@ -33,7 +33,7 @@ Notifier = typing.Literal["mattermost", "slack"]
NOTIFIERS: tuple[Notifier, ...] = typing.get_args(Notifier)
# An optional boolean setting: whether `chunk-pr merge` waits for a human's approval of the pull request. False where left out.
WAIT_FOR_APPROVAL = "wait-for-approval"
# An optional setting: who merges a chunk's pull request, one of MERGERS. The chunk does where it is left out; under "human", `chunk-pr merge` leaves the pull request ready for a person to merge, for a team whose rules keep the merge with a person.
# An optional setting: who merges a chunk's pull request, one of MERGERS; the chunk where it is left out.
MERGE = "merge"
Merger = typing.Literal["chunk", "human"]
MERGERS: tuple[Merger, ...] = typing.get_args(Merger)