Answer the prose review's first round

This commit is contained in:
2026-10-02 17:33:04 +02:00
parent 5b5e01ed9d
commit 7fad122df6
2 changed files with 5 additions and 6 deletions
+3 -4
View File
@@ -24,12 +24,11 @@ How work proceeds in any repo, unless the repo's `AGENTS.md` says otherwise. The
## Quality
Quality is proven by review. Every change is reviewed as a diff. The whole project is measured when a change carries an architectural decision, and before each release, because a project can drift from the principles one clean diff at a time. `larv-review` §3 says which review runs when. Quality has four parts. When two pull against each other, the earlier one wins.
Quality is proven by review. Every change is reviewed as a diff. The whole project is measured when a change carries an architectural decision, and before each release, because a project can drift from the principles one clean diff at a time. `larv-review` §3 says which review runs when. Quality has three parts. When two pull against each other, the earlier one wins.
1. **Correct.** The work does what the goals and the plan say, and tests prove it.
2. **True to the technical principles** (`~/.claude/principles/technical-principles.md`).
3. **Easy to comprehend**, per KISS in the technical principles. The `comprehension-panel` skill scores the project; a score under the comprehension floor (`larv-review` §3 → "Architecture") blocks a merge, and the aim is always higher.
4. **Plainly written**, per "Prose".
2. **True to the technical principles** (`~/.claude/principles/technical-principles.md`). The `comprehension-panel` skill scores KISS; a score under the comprehension floor (`larv-review` §3 → "Architecture") blocks a merge, and the aim is always higher.
3. **Plainly written**, per "Prose".
## Prose
+2 -2
View File
@@ -55,8 +55,8 @@
* Deterministic order wherever order carries no meaning.
- Sort it, on a key that does not move: the name a line introduces, never where it came from. A sorted list is searchable, its diff shows only what changed, and two edits to it conflict only where they mean to.
- An import sorts on its first binding, not its path, so moving or renaming a module reorders nothing. Where lines already group by kind — type imports, host packages — the key sorts within each group.
* Keep It Simple, Stupid (KISS): a reader new to the project understands it on one read.
- A size or complexity limit stands only while the comprehension panel agrees with what it flags.
* Keep It Simple, Stupid (KISS): keep solutions simple, so a reader new to the project understands each part on one read.
- Keep a size or complexity limit only while the readers of the comprehension panel (`~/.claude/skills/comprehension-panel/`) find hard what the limit flags.
* Don't Repeat Yourself (DRY): one authoritative home per piece of knowledge, one obvious way per need.
- A value, rule, definition or concept lives in one place, and everywhere else derives it from there or points at it. A copy that can drift is a second spelling: derive it from its owner, or, for config a human writes, reject it where it is read and name the owner.
- Before adding a way to do something, find the existing one and use it. The same goes for tests: extend an existing test with an assertion before writing a new one. Where two spellings serve the same caller for the same need, keep one and reject the other as early as possible — at load, parse or compile — with an error naming the one to use: `token {p} renders a level that {p.first} reads a path into; name the fields you want instead`.