Record the comprehension check: a scoring run at bcb04e3, overall 6.00; refresh floor item 300
CI / tests (pull_request) Successful in 2m23s
CI / tests (pull_request) Successful in 2m23s
This commit is contained in:
@@ -3819,3 +3819,57 @@ Inherited architect, decided by:
|
||||
- Locality: `bin/review_rules/review_folder.py:17` `made_review_folder`: `home` is passed in from the command table, so each unit's inputs show in its signature; at the base `Path.home()` was read deep inside
|
||||
- Shape: `bin/larv_review/scoring_setup.py:169` `prepare_scoring`: counts against the change: about 75 lines with a dozen early returns, and `prompt_parts` builds one path twice
|
||||
- Shape: `bin/review_rules/round_titles.py:13` `OPENING`: the round-title spelling is written once next to the regexes that parse it
|
||||
|
||||
## 2026-11-15T21:26:29Z, PR #554 at bcb04e3
|
||||
|
||||
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|
||||
|---|---|---|---|---|---|
|
||||
| Junior A | 6.5 | 5 | 5.5 | 5 | 5.5 |
|
||||
| Mid A | 7 | 6 | 6.5 | 6 | 6.5 |
|
||||
| Maintainability senior | 7 | 5.5 | 6 | 6 | 6 |
|
||||
| Inherited architect | 6.5 | 6 | 5.5 | 5.5 | 6 |
|
||||
| Mean | 6.75 | 5.63 | 5.88 | 5.63 | 6.00 |
|
||||
|
||||
Junior A, hardest first:
|
||||
|
||||
- Locality, Self-sufficiency: `bin/loop_claude/routing.py:113` `unfinished_route`: five rung notions, two step-up counters and a seven-row verdict table at once, and the reasons in the decision log
|
||||
- Shape: `bin/release_plan/release_standing.py:162` `next_release`: many edge-case branches and `str | None | Failure` threaded through every field of `LastCut`
|
||||
- Locality, Shape: `bin/loop_claude/cycle/run.py:151` `rule`: judges, stamps, annotates, steps the rung up and archives, and no single unit owns the archive's order
|
||||
- Self-sufficiency: `bin/loop_claude/cycle/judge.py:22` `INTERRUPT_RULES`: policy partly in prompt text and partly in Python checks, with nothing saying which the code enforces
|
||||
- Locality: `bin/loop_claude/loop/reload.py:95` `exec_if_edited`: an edit to any `.py` under `bin/` makes a running loop re-exec, and a renamed `LoopRun` field breaks the reload
|
||||
- Shape: `bin/model_routing/ladder.py:86` `review_rung`: a three-way rule whose docstring quotes a whole decision title
|
||||
- Self-sufficiency: `bin/larv_review/main.py:1` module docstring: twelve subcommands' rules in about 155 lines of prose that cross-reference SKILL.md
|
||||
- Shape: `bin/loop_claude/loop/chunk_start.py:24` `fetched_todo`: nearly the same plan read as `fetched_plan`, told apart only by a docstring
|
||||
|
||||
Mid A, hardest first:
|
||||
|
||||
- Shape: `bin/release_plan/release_standing.py:162` `next_release`: a three-state tag, `BEFORE_FIRST_RELEASE`, `nothing_cut` and `is_earliest` held at once, and comments that explain each branch alone
|
||||
- Locality: `bin/loop_claude/routing.py:113` `unfinished_route`: five rungs, the escalation mark and the unfinished count feed one answer across three files
|
||||
- Locality, Shape: `bin/chunk_pr/main.py:298` `merged`: a while loop around the queue turn, variables bound only on some paths, and no comment stating the loop's invariant
|
||||
- Shape: `bin/chunk_preflight/main.py:128` `preflight`: lines 142-143 pack a conditional re-`located` and an eight-argument `Gathered` into two lines
|
||||
- Shape: `bin/release_plan/ranking.py:48` `rank`: two table shapes branch through the whole module, and the defect rule sits far from where scores are read
|
||||
- Self-sufficiency: `bin/larv_review/plan.py:77` `plan_reasons`: six inputs joined into one answer, and why each matters is in SKILL.md §3
|
||||
- Shape: `bin/rule_hook/env_file.py:34` `reaching`: `and` and `or` mixed without parentheses, and four path spellings in a lookaround regex
|
||||
- Self-sufficiency: `bin/loop_claude/cycle/judge.py:197` `quotes_checked`: long prompt text inside the `Reply` field metadata mixes the prompt with the schema
|
||||
|
||||
Maintainability senior, hardest first:
|
||||
|
||||
- Locality, Shape: `bin/chunk_pr/main.py:298` `merged`: a while loop holding a queue turn, approval waits and a `done` set only on some paths, with no loop invariant stated
|
||||
- Locality, Self-sufficiency: `bin/loop_claude/routing.py:113` `unfinished_route`: five rungs, the escalation count and the mark from another file, and each step's reason in the decision log
|
||||
- Locality, Self-sufficiency: `skills/larv-review/SKILL.md:146` "Comprehension check": paragraphs of four or five conditions, each pointing to a hook, a CLI's help or another rule file
|
||||
- Shape: `bin/release_plan/release_standing.py:162` `next_release`: three sources of a cut, the `is_earliest` expression and `LastCut` fields typed `str | None | Failure`
|
||||
- Shape: `bin/release_plan/ranking.py:136` `weigh`: two live table shapes double every path, and `Shape` is built from positional tuples of callables
|
||||
- Locality, Shape: `bin/loop_claude/cycle/run.py:151` `rule`: judges, stamps, archives and steps up, beside a 17-field `Cycle` passed around whole
|
||||
- Shape: `bin/chunk_pr/main.py:438` `remeasure`: control flow inside chained `isinstance(x, Failure) or …` expressions, and `finished` unpacks five runs by position
|
||||
- Shape: `bin/chunk_preflight/main.py:128` `preflight`: the whole fallback logic packed into lines 142-143
|
||||
|
||||
Inherited architect, would restructure first:
|
||||
|
||||
- Navigation, Shape: `README.md:193` the `bin/` roles: about 70 flat entries under `bin/`, where only this list tells a tool from a library
|
||||
- Navigation, Shape: `bin/larv_review/main.py:222` `COMMANDS`: the package named for the review mostly holds the comprehension check, and the review loop is prose in SKILL.md
|
||||
- Locality, Shape: `bin/chunk_pr/main.py:384` `levelled_and_finished`: merges, finishes items, pushes, asks whether a scoring run is owed and remeasures under a name that gives two of the five
|
||||
- Locality: `bin/chunk_pr/main.py:349` `unplanned`: matches the error text of `todo-item show`, as `finished` does, where `plan_store` reads the plan
|
||||
- Navigation: `bin/rule_hook/round_cap.py:10` `round_cap_breaches`: the round cap is enforced in the hook, not in `larv_review`, where a reader looks first
|
||||
- Shape: `bin/deploy_release/forge.py:1` module: the forge lives in `deploy_release` and in `chunk_preflight.choices.forge_of`, neither a home its name gives
|
||||
- Shape: `bin/rule_hook/rules.py:26` `RULES`: the file is the registry and also four rules' checkers, so where a new rule goes is undecided
|
||||
- Self-sufficiency: `bin/plan_store/stores.py:5` module docstring: cites plan items 365, 366 and 368 as part of the contract, as routing and ladder code cite decisions
|
||||
|
||||
@@ -46,7 +46,7 @@
|
||||
| 273 | 0.14.0 | | decision | **Re-tune the E + I steps of `REVIEW_STEPS` for 6 to 8 once 10 finished chunks have scored an E + I of 6 or more, from how well E + I orders their review rounds and 🔴 findings.** | 1 | 2 | 2 | 3 | 2 | 1.1 by 2, 1.4 by 3 | 2.0 |
|
||||
| 268 | 0.14.0 | | | **End a run whose release is ready to cut with a notice on loop-claude's terminal, in place of an interrupt that waits for an answer.** | 2 | 2 | 3 | 5 | 3 | 1 by 5 | 1.9 |
|
||||
| 171 | 0.14.0 | | decision | **Group the routing figures' review rounds by the reviewers' rung as well as the worker's, so a call blames a rung only for rounds its own reviews raised.** | 3 | 2 | 2 | 5 | 4 | 1.2 by 3, 1.4 by 3 | 1.8 |
|
||||
| 300 | 0.14.0 | | owner | **Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality and Self-sufficiency first; today the scoring run at 8f03747 scored Navigation 6.75, Locality 5.63, Shape 5.75, Self-sufficiency 5.63 and Overall 6.00.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 1.7 |
|
||||
| 300 | 0.14.0 | | owner | **Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality and Self-sufficiency first; today the scoring run at bcb04e3 scored Navigation 6.75, Locality 5.63, Shape 5.88, Self-sufficiency 5.63 and Overall 6.00.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 1.7 |
|
||||
| 264 | 0.14.0 | | | **Report the comprehension seats and the escalated subagents as subagent types of their own in `routing-figures.md`, with their dollars.** | 2 | 2 | 1 | 3 | 3 | 1.4 by 5 | 1.7 |
|
||||
| 323 | 0.14.0 | | | **Count a release review as landed once its pull request has merged, whatever its commits are titled.** | 3 | 2 | 3 | 6 | 3 | 1.4 by 3, 1.5 by 2 | 1.7 |
|
||||
| 342 | 0.14.0 | | | **Research the tooling agents read, search and run commands with once more, and file an item for each tool that cuts tokens a replay shows keep quality.** | 1 | 2 | 1 | 2 | 3 | 1.4 by 3, 1.5 by 2 | 1.7 |
|
||||
@@ -328,28 +328,30 @@ Releases are the human's, and `CLAUDE.md` → "Working loop" already ends the lo
|
||||
|
||||
Raised by the goals audit of PR #296. `bin/routing_figures/calls.py` groups a chunk's review rounds by the rung its worker started on, and calls for a routing change when a lower rung took more of them. Since PR #296 the reviewers may run above the worker's rung, on the one their item's E + I picks, and no figure groups rounds by it, though the archived worker line names the E + I it follows from. A cheap worker on an item of high E + I gets stronger reviewers, who may raise more rounds, and a call could then blame the worker's rung for them: an interrupt of lilleman that settles nothing (goal 1.2).
|
||||
|
||||
### 300. Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality and Self-sufficiency first; today the scoring run at 8f03747 scored Navigation 6.75, Locality 5.63, Shape 5.75, Self-sufficiency 5.63 and Overall 6.00.
|
||||
### 300. Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality and Self-sufficiency first; today the scoring run at bcb04e3 scored Navigation 6.75, Locality 5.63, Shape 5.88, Self-sufficiency 5.63 and Overall 6.00.
|
||||
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the second run of PR #520 at 8f03747. The lowest means are Locality and Self-sufficiency, 5.63 each: the seats name state shared across modules, such as the route and the archive order, and reasons that sit in `docs/decisions.md`, `CLAUDE.md` or `skills/larv-review/SKILL.md` rather than beside the code. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the run of PR #554 at bcb04e3. The lowest means are Locality and Self-sufficiency, 5.63 each: the seats name state shared across modules, such as the route and the archive order, and reasons that sit in `docs/decisions.md`, `CLAUDE.md` or `skills/larv-review/SKILL.md` rather than beside the code. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
|
||||
Aim: one ambitious refactor of the areas below, sized so every mean reaches 7.0 on the chunk's own scoring run. Where a place is already easier to read when the chunk starts, drop it.
|
||||
|
||||
Places the seats named, hardest first (`larv-review places`):
|
||||
|
||||
- Locality, Self-sufficiency: `bin/loop_claude/routing.py:93` `unfinished_route`, with `escalated_route`: the floor, the cap counted from `item_rung`, the escalation mark, the unfinished count and the E + I taken in are held at once across four files, and why they combine sits in the decision log. Every seat named it; three would least want to change it.
|
||||
- Shape, Self-sufficiency: `bin/release_plan/release_standing.py:168` `next_release`, with `standing`: `str | None | Failure` fields in `LastCut`, the `BEFORE_FIRST_RELEASE` sentinel and `nothing_cut` meet in the `is_earliest` test, read as truth tables; four tools choose the next release through it.
|
||||
- Locality: `bin/loop_claude/cycle/run.py:154` `rule`, with `:67` `run_cycle` and `:94` `archived`: archives twice in an order that matters and that nothing enforces, the archive helpers sit in the cycle runner though `loop/close.py` imports them, and `run_cycle` replaces `cycle.route` outside the state machine.
|
||||
- Shape: `bin/release_plan/ranking.py:47` `rank`, `:134` `weigh`, `:229` `score` and `:240` `weight_of`: every function forks on `SHAPE` versus `OLD_SHAPE`, and the constants' reasons are only "docs/decisions.md records the choice".
|
||||
- Shape: `bin/rule_hook/todo_check.py:22` `todo_breaches`, with `:42` `folder_breaches`: three paths, `held()` beside `located()`, the checkout's own script only under `same_repo`, and a blob hashed by hand.
|
||||
- Locality, Self-sufficiency: `bin/larv_review/plan.py:66` `plan_reasons` and `bin/larv_review/owed.py:46` `shortfall`: the rule for when a scoring run is due is split between the 155-line help and the code, and the number owed hangs on the wording `EMPTIED_WORDS`.
|
||||
- Self-sufficiency: `bin/loop_claude/cycle/judge.py:21` `INTERRUPT_RULES`, with `:196` `quotes_checked`: behaviour held in prompt text and schema descriptions the code can't explain, and prompts that quote `CLAUDE.md` wording.
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:82` "Round cap": dense rules that point at `CLAUDE.md`, `review-findings.md` and the rules files, read three times before the code matched.
|
||||
- Self-sufficiency: `bin/rule_hook/round_cap.py:26` `earlier_titles`: fails open on the unattended path where git cannot list the branch's titles, and the round title is spelt by hand in SKILL.md, `larv_review/main.py` and `reviewer_header.py` beside `round_titles.py`.
|
||||
- Locality, Shape: `bin/chunk_preflight/choices.py:80` `forge_of`: forge identity and forge calls live in two tool packages, so a second forge lands in three.
|
||||
- Navigation, Shape: `README.md:131` `bin/`: about 63 entries at one level, the shared libraries told apart only by README prose.
|
||||
- Shape: `bin/loop_claude/loop/reload.py:220` `decoded_route`: one dense guard, and renaming a `LoopRun` field stops a running loop.
|
||||
- Shape: `README.md:3` trial folders: four finished experiments at the root beside the working areas.
|
||||
- Self-sufficiency: the seats on this run name the decision-log titles that code cites for a constant's reason (`routing: …` in `routing.py`, `ladder.py`, `judge.py`) as the largest cost; state each reason beside its constant.
|
||||
- Locality, Self-sufficiency: `bin/loop_claude/routing.py:113` `unfinished_route`, with `:128` `escalated_route`: five rungs, the escalation mark from `escalation_mark.py`, the unfinished count from `loop/close.py` and two step-up counters are held at once, and why they combine sits in the decision log. Three seats named it; one would least want to change it.
|
||||
- Locality, Shape: `bin/chunk_pr/main.py:298` `merged`, with `:384` `levelled_and_finished`, `:349` `unplanned`, `:407` `finished` and `:438` `remeasure`: a while loop around the queue turn binds `ready`, `asked` and `done` only on some paths and states no invariant; `levelled_and_finished` does five things under a name that gives two; `unplanned` and `finished` match the error text of `todo-item show` where `plan_store` reads the plan; `remeasure` keeps its control flow in chained boolean expressions. Three seats named it; two would least want to change it, and one expects the next defect there.
|
||||
- Shape, Self-sufficiency: `bin/release_plan/release_standing.py:162` `next_release`, with `:207` `standing`: `str | None | Failure` fields in `LastCut`, the `BEFORE_FIRST_RELEASE` sentinel and `nothing_cut` meet in the `is_earliest` test at `:184`, and the comments explain each branch alone.
|
||||
- Locality, Shape: `bin/loop_claude/cycle/run.py:151` `rule`, with the 17-field `Cycle` at `:31`: judges, stamps, annotates, steps the rung up and archives in an order that matters and that no single unit owns, and `Cycle` is passed around whole.
|
||||
- Shape: `bin/release_plan/ranking.py:48` `rank`, `:136` `weigh` and `:231` `score`: every function forks on `SHAPE` versus `OLD_SHAPE`, `Shape` is built from positional tuples of callables, and the defect rule sits in `weight_of`, far from where scores are read.
|
||||
- Shape: `bin/chunk_preflight/main.py:128` `preflight`: lines 142-143 pack a conditional re-`located` and an eight-argument `Gathered` into two lines.
|
||||
- Locality, Self-sufficiency: `skills/larv-review/SKILL.md:146` "Comprehension check", with `:82` "Round cap", `bin/larv_review/main.py:1` and `bin/larv_review/plan.py:77` `plan_reasons`: one rule is spread over skill prose, a 155-line help, a hook and the code, so rebuilding it means three files open.
|
||||
- Navigation, Shape: `bin/larv_review/main.py:222` `COMMANDS` and `bin/rule_hook/round_cap.py:10` `round_cap_breaches`: the package named for the review mostly holds the comprehension check, part of which sits in `review_rules/comprehension_history.py`, and the round cap is enforced in the hook, where a reader looks last.
|
||||
- Self-sufficiency: `bin/loop_claude/cycle/judge.py:22` `INTERRUPT_RULES`, with `:197` `quotes_checked`: behaviour held partly in prompt text and schema descriptions and partly in Python checks, with nothing saying which the code enforces.
|
||||
- Locality, Shape: `bin/deploy_release/forge.py:1` and `bin/chunk_preflight/choices.py` `forge_of`: forge identity and forge calls live in two tool packages, neither a home the name gives.
|
||||
- Navigation, Shape: `README.md:193` `bin/`: about 70 entries at one level, the shared libraries told apart only by README prose.
|
||||
- Shape: `bin/rule_hook/rules.py:26` `RULES`: the registry and four rules' checkers in one file, so where a new rule goes is undecided.
|
||||
- Locality: `bin/loop_claude/loop/reload.py:95` `exec_if_edited`, with `:67` `decoded_route`: an edit under `bin/` makes a running loop re-exec, and renaming a `LoopRun` field stops it.
|
||||
- Shape: `bin/rule_hook/env_file.py:34` `reaching`: `and` and `or` mixed without parentheses, and four path spellings in one lookaround regex.
|
||||
- Shape: `bin/loop_claude/loop/chunk_start.py:24` `fetched_todo`: nearly the same plan read as `:75` `fetched_plan`, told apart only by a docstring.
|
||||
- Self-sufficiency: every seat names the decision-log titles and plan items that code cites for a reason (`routing.py`, `ladder.py`, `run.py:31`, `plan_store/stores.py:5` and `:50`, `chunk_start.py:86`) as the largest cost; state each reason beside its constant and keep the citation as a footnote.
|
||||
|
||||
Scored L 4 because the refactor touches several components that hold known defects, E 2 because review and a manual check see a regression, I 3 because every session runs these tools. The chunk runs a scoring run, since it is a floor item.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user