Record the comprehension check: two scoring runs at 81e8d8a1, Overall 6.50 and 5.88, and refresh floor item 300
CI / tests (pull_request) Has been cancelled
CI / tests (pull_request) Has been cancelled
This commit is contained in:
@@ -4011,3 +4011,111 @@ Inherited architect, decided by:
|
||||
- Locality: `bin/chunk_pr/main.py:130` `step`: the config is passed in once, where `misfit` shelled out to `project-config` twice
|
||||
- Shape: `bin/project_config/settings.py:320` `SCALARS`: one row per one-value setting, where `load` handled each at four sites
|
||||
- Navigation, Self-sufficiency: `bin/chunk_preflight/gathered.py:60` `Gathered.plan`: a stale pointer to `choices.plan_name`, with two more in `next_chunk.py` and the README, small next to the gains
|
||||
|
||||
## 2026-11-19T09:23:24Z, PR #633 at 81e8d8a1
|
||||
|
||||
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|
||||
|---|---|---|---|---|---|
|
||||
| Junior A | 7 | 6 | 6 | 5.5 | 6 |
|
||||
| Mid A | 7 | 6 | 6.5 | 5.5 | 6.5 |
|
||||
| Maintainability senior | 7.5 | 6.5 | 6.5 | 6.5 | 7 |
|
||||
| Inherited architect | 7 | 7 | 6 | 6 | 6.5 |
|
||||
| Mean | 7.13 | 6.38 | 6.25 | 5.88 | 6.50 |
|
||||
|
||||
Junior A, hardest first:
|
||||
|
||||
- Locality: `bin/do_epic/main.py:283` `parked_through`: one polling loop carries five mutable locals against a `now` of four types, and a nested conditional must be traced by hand
|
||||
- Locality: `bin/do_epic/scheduler.py:136` `start_chunks`: four overlapping sets feed an elif chain whose arm order decides the outcome, under a lock with a second one inside
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:97` "Re-entry": dense rules held at once with the round cap, pointing out to other files
|
||||
- Locality, Self-sufficiency: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rungs, a counter and a mark live at once; the why of the caps is only in the decision log
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: six quote checks each with its own fallback; the prompt constants are behaviour guarded by one comment
|
||||
- Locality: `bin/loop_claude/loop/main.py:108` `next_cycle`: the order of steps carries meaning the code doesn't state
|
||||
- Locality: `bin/chunk_pr/main.py:429` `levelled_and_finished`: order-dependent steps that comments state and nothing enforces
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES`: a rule's only specification is one long sentence with nested unless clauses
|
||||
|
||||
Mid A, hardest first:
|
||||
|
||||
- Locality: `bin/agent_cycle/routing.py:115` `unfinished_route`: interacting rungs, a counter and an escalation mark; the module table resolves it
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: the prompt text is behaviour written as English
|
||||
- Shape: `bin/loop_claude/cycle/prompts.py:132` `escalation`: a prompt assembled from pieces that may each be empty
|
||||
- Locality: `bin/agent_cycle/run.py:150` `rule`: the order of stamping, archiving and stepping matters across functions
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES`: rule text doubles as specification and help
|
||||
- Shape: `bin/rule_hook/endless_wait.py:93` `self_match`: long lines and a regex whose cases need a second read
|
||||
- Locality: `bin/loop_claude/loop/chunk_windows.py:107` `may_start`: depends on state kept out of sight
|
||||
- Self-sufficiency: `bin/larv_review/plan.py:80` `plan_reasons`: reasons whose meaning lives in the skill's text
|
||||
- Locality: `bin/model_routing/route.py:42` `Route`: fields used as archive keys elsewhere; the unit this seat least wanted to modify
|
||||
|
||||
Maintainability senior, hardest first:
|
||||
|
||||
- Locality: `bin/do_epic/main.py:283` `parked_through`: five mutable locals in one polling loop, and an empty string that means "never parked"
|
||||
- Locality: `bin/chunk_pr/main.py:429` `levelled_and_finished`: order-dependent steps, and a context manager that yields a Failure instead of raising
|
||||
- Locality, Shape: `bin/do_epic/scheduler.py:136` `start_chunks`: overlapping sets and an elif chain under nested locks
|
||||
- Self-sufficiency: `bin/agent_cycle/routing.py:115` `unfinished_route`: the why of the caps sits in the decision log
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: fallbacks change the verdict's type without a signal at the call site
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES` env-file-read: a 130-word sentence is the rule's only specification
|
||||
- Shape: `bin/plan/ranking.py:239` `score`: two table shapes double the branches
|
||||
- Locality: `bin/agent_cycle/run.py:240` `close`: closing steps whose order matters across the module
|
||||
|
||||
Inherited architect, would restructure first:
|
||||
|
||||
- Shape: `bin/` root: about 85 entries at once with no split between tools and libraries
|
||||
- Locality: `bin/do_epic/main.py:11` imports: do_epic reaches into loop_claude's internals
|
||||
- Navigation: `bin/loop_claude/cycle/` the folder: the name misleads after its code moved to agent_cycle
|
||||
- Navigation: `bin/agent_cycle/verdicts.py:1` the module: names left from before the move
|
||||
- Shape: `bin/agent_cycle/run.py:38` `Cycle`: the config, judge and project fields widen a 16-field value
|
||||
- Shape: `bin/larv_review/reviewer_header.py:121` `Launch`: built positionally
|
||||
- Self-sufficiency: `bin/larv_review/plan.py:25` the module: no docstring says what it holds
|
||||
|
||||
## 2026-11-19T09:27:43Z, PR #633 rerun at 81e8d8a1
|
||||
|
||||
| Seat | Navigation | Locality | Shape | Self-sufficiency | Overall |
|
||||
|---|---|---|---|---|---|
|
||||
| Junior A | 6.5 | 5 | 6 | 4.5 | 5.5 |
|
||||
| Mid A | 7 | 6 | 6.5 | 6 | 6.5 |
|
||||
| Maintainability senior | 7 | 5.5 | 6 | 5.5 | 6 |
|
||||
| Inherited architect | 6.5 | 6 | 5 | 5 | 5.5 |
|
||||
| Mean | 6.75 | 5.63 | 5.88 | 5.25 | 5.88 |
|
||||
|
||||
Junior A, hardest first:
|
||||
|
||||
- Locality, Self-sufficiency: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rungs, a count and the escalation mark held at once; the why sits in the decision log and `escalation_mark.py` `checked` must be open beside it
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: six kinds of quote each fail differently, and half the behaviour is prompt text whose load-bearing sentences can't be told apart
|
||||
- Self-sufficiency: `skills/larv-review/SKILL.md:97` "Re-entry": rules with exceptions to exceptions, cross-referencing other sections and files
|
||||
- Locality, Shape: `bin/agent_cycle/run.py:150` `rule`: a 16-field `Cycle`, long one-line calls, and an archive-before-step-up order only reading order tells
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES`: each rule is one enormous sentence, and its check lives in another module
|
||||
- Locality: `bin/loop_claude/loop/chunk_windows.py:107` `may_start`: sets that depend on tmux and lock state out of sight, a lock a second program also takes
|
||||
- Locality: `bin/loop_claude/loop/reload.py:69` `decoded_route`: renaming a field stops running loops, and nothing warns at the other end
|
||||
- Locality: `bin/do_epic/main.py:118` `run`: argv parsed through interacting booleans, and imports of loop_claude internals
|
||||
|
||||
Mid A, hardest first:
|
||||
|
||||
- Locality: `bin/do_epic/main.py:283` `parked_through`: a polling loop holds four variables across three result types, a three-deep chained conditional, and `on is None` doubling as the first pass; the unit this seat least wanted to modify
|
||||
- Locality, Self-sufficiency: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rungs plus a count and a mark held together; the why is cited to the decision log
|
||||
- Locality: `bin/do_epic/scheduler.py:136` `start_chunks`: four window sets feed a five-arm chain whose meaning changes with `own`, inside two nested flocks shared with loop-claude
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: six quote kinds fail differently; much behaviour is an English prompt, and `TASK_HEADING` is silently an archive format
|
||||
- Locality: `bin/project_config/settings.py:182` `load`: a 20-entry list of cross-setting rules, and an assert that depends on it being complete
|
||||
- Locality: `bin/chunk_pr/main.py:429` `levelled_and_finished`: a load-bearing order and a short-circuit hidden in `failed or run(...)`
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES`: each contract is a long English sentence, and nothing ties it to the checking code in eight sibling modules
|
||||
- Shape: `bin/agent_cycle/stuck_workers.py:52` `Watch.check`: the condition at line 59 mixes `or` and `and` without parentheses over dicts mutated across ticks
|
||||
|
||||
Maintainability senior, hardest first:
|
||||
|
||||
- Locality: `bin/do_epic/main.py:283` `parked_through`: four mutable locals across iterations, a side effect correct only because `on` is reassigned later, and a crash-ordering invariant across three stores; the unit this seat least wanted to modify
|
||||
- Locality: `bin/do_epic/scheduler.py:136` `start_chunks`: four overlapping sets from two stores feed a five-arm ladder, and a parked chunk silently restarts down the no-repo path
|
||||
- Locality: `bin/loop_claude/loop/chunk_windows.py:107` `may_start`: depends on window names and options, dead flags, archived lines, a flock and predictions, with the schema in `agent_cycle/tmux.py`
|
||||
- Locality: `bin/agent_cycle/routing.py:115` `unfinished_route`: five rungs plus a count and the mark; the table resolves it, the why is in the decision log
|
||||
- Locality: `bin/chunk_pr/main.py:429` `levelled_and_finished`: a load-bearing order held together by one-liners where a Failure's truthiness carries the control flow
|
||||
- Shape: `bin/agent_cycle/run.py:150` `rule`: archive-then-step-up order, several exits, and very long single-line expressions
|
||||
- Locality: `bin/project_config/settings.py:182` `load`: one list encodes the whole validation matrix, whose interactions don't read
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`: six quote kinds with different fallbacks; `INTERRUPT_RULES` is behaviour no code can check
|
||||
|
||||
Inherited architect, would restructure first:
|
||||
|
||||
- Locality, Self-sufficiency: `skills/larv-review/SKILL.md:89` "Round cap": the cap is spread across three packages and this prose, and nothing in code counts a reviewer's launches
|
||||
- Locality: `bin/do_epic/main.py:11` imports: do_epic reaches into eight loop_claude modules, over a wire format a renamed field breaks
|
||||
- Navigation: `bin/loop_claude/cycle/` the folder: it holds prompts and chunk items while the cycle is agent_cycle
|
||||
- Shape: `bin/agent_cycle/verdicts.py:1` the module: its docstring names a `cycle.` package that is now agent_cycle
|
||||
- Shape: `bin/` root: about 80 entries with no grouping, indexed by one dense README paragraph
|
||||
- Navigation: `bin/loop_state/paths.py:6` `Paths`: neither state nor loop-specific
|
||||
- Self-sufficiency: `bin/larv_review/plan.py:25` `scoring_run_due`: the module holds the scoring-run trigger and has no docstring
|
||||
- Locality: `bin/review_rules/review_passes.py:8` `PASS_AGENTS`: code constants that must match sentences in SKILL.md
|
||||
|
||||
@@ -35,7 +35,7 @@
|
||||
| 273 | 0.14.0 | | decision | **Re-tune the E + I steps of `REVIEW_STEPS` for 6 to 8 once 10 finished chunks have scored an E + I of 6 or more, from how well E + I orders their review rounds and 🔴 findings.** | 1 | 2 | 2 | 3 | 2 | 1.1 by 2, 1.4 by 3 | 2.0 |
|
||||
| 268 | 0.14.0 | | | **End a run whose release is ready to cut with a notice on loop-claude's terminal, in place of an interrupt that waits for an answer.** | 2 | 2 | 3 | 5 | 3 | 1 by 5 | 1.9 |
|
||||
| 171 | 0.14.0 | | decision | **Group the routing figures' review rounds by the reviewers' rung as well as the worker's, so a call blames a rung only for rounds its own reviews raised.** | 3 | 2 | 2 | 5 | 4 | 1.2 by 3, 1.4 by 3 | 1.8 |
|
||||
| 300 | 0.14.0 | | owner | **Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first; today the scoring run at 55235a0 scored Navigation 7.38, Locality 6.13, Shape 6.50, Self-sufficiency 6.50 and Overall 6.50.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 1.7 |
|
||||
| 300 | 0.14.0 | | owner | **Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Self-sufficiency first; today the scoring runs at 81e8d8a1 scored Navigation 7.13 and 6.75, Locality 6.38 and 5.63, Shape 6.25 and 5.88, Self-sufficiency 5.88 and 5.25, and Overall 6.50 and 5.88.** | 4 | 2 | 3 | 7 | 8 | code health by 8 | 1.7 |
|
||||
| 264 | 0.14.0 | | | **Report the comprehension seats and the escalated subagents as subagent types of their own in `routing-figures.md`, with their dollars.** | 2 | 2 | 1 | 3 | 3 | 1.4 by 5 | 1.7 |
|
||||
| 323 | 0.14.0 | | | **Count a release review as landed once its pull request has merged, whatever its commits are titled.** | 3 | 2 | 3 | 6 | 3 | 1.4 by 3, 1.5 by 2 | 1.7 |
|
||||
| 342 | 0.14.0 | | | **Research the tooling agents read, search and run commands with once more, and file an item for each tool that cuts tokens a replay shows keep quality.** | 1 | 2 | 1 | 2 | 3 | 1.4 by 3, 1.5 by 2 | 1.7 |
|
||||
@@ -290,29 +290,26 @@ Releases are the human's, and `CLAUDE.md` → "Working loop" already ends the lo
|
||||
|
||||
Raised by the goals audit of PR #296. `bin/routing_figures/calls.py` groups a chunk's review rounds by the rung its worker started on, and calls for a routing change when a lower rung took more of them. Since PR #296 the reviewers may run above the worker's rung, on the one their item's E + I picks, and no figure groups rounds by it, though the archived worker line names the E + I it follows from. A cheap worker on an item of high E + I gets stronger reviewers, who may raise more rounds, and a call could then blame the worker's rung for them: an interrupt of lilleman that settles nothing (goal 1.2).
|
||||
|
||||
### 300. Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Locality first; today the scoring run at 55235a0 scored Navigation 7.38, Locality 6.13, Shape 6.50, Self-sufficiency 6.50 and Overall 6.50.
|
||||
### 300. Reach the comprehension floor: restructure the places the comprehension seats found hardest to follow, so the project reads at 7.0 or above on every dimension, Self-sufficiency first; today the scoring runs at 81e8d8a1 scored Navigation 7.13 and 6.75, Locality 6.38 and 5.63, Shape 6.25 and 5.88, Self-sufficiency 5.88 and 5.25, and Overall 6.50 and 5.88.
|
||||
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the two runs of PR #560 at 55235a0. The lowest mean is Locality, 6.13 in both runs: the seats name rules held partly in agent-facing prose and partly in code, and state that one unit can't be read without three others open. Self-sufficiency and Shape follow at 6.50. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
Filed by the comprehension check of PR #473 at 13d1550 (`larv-review record-scoring`), which printed `Floor:` and `Next:`, and refreshed from the two runs of PR #633 at 81e8d8a1. The lowest mean is Self-sufficiency: 5.88 in the first run and 5.25 in the second. Every seat says the same thing: the vocabulary lives only in `CLAUDE.md` → "Vocabulary", the why of thresholds and orderings sits behind `docs/decisions.md → …` pointers, and behaviour lives in prose that no code ties to its check. Locality follows, at 6.38 and 5.63: scheduling state lives in tmux window names, state files and flocks across three packages. Refresh this item's places and aim from the newest run before the chunk starts; do not file a second floor item.
|
||||
|
||||
Aim: one ambitious refactor of the areas below, sized so every mean reaches 7.0 on the chunk's own scoring run. Where a place is already easier to read when the chunk starts, drop it.
|
||||
|
||||
Places the seats named, hardest first (`larv-review places`), Locality first:
|
||||
Places the seats named, hardest first (`larv-review places`), Self-sufficiency first:
|
||||
|
||||
- Locality, Self-sufficiency: `bin/release_plan/release_standing.py:176` `next_release`, with `:162` `carried`: the cut from a tag, a dated heading or `BEFORE_FIRST_RELEASE`, release names replayed from the plan's history, and renames meet in the `is_earliest` test at `:198`; `carried` is reapplied in `chunk_item` and in `chunk_preflight/choices.py` `planned`, one relying on `zip` keeping order. All eight seats named it; four would least want to change it.
|
||||
- Locality: `bin/agent_cycle/routing.py:116` `unfinished_route`, with `:131` `escalated_route`: five rungs, the unfinished count and the escalation mark, which spans `escalation_mark.py`, `judge.py`, `verdicts.py`, `route.py` and `reload.py`. Seven seats named it; the module table is what makes it readable.
|
||||
- Locality: `bin/chunk_pr/main.py:298` `merged`, with `:384` `levelled_and_finished` and `:407` `finished`: a loop around the queue turn binds `done` only under some `if ready` branches, the approval wait is a fall-through, and `finished` destructures five subprocess results by position.
|
||||
- Locality: `skills/larv-review/SKILL.md:82` "Round cap" and `:90` "Re-entry", with `bin/review_rules/round_titles.py:45` and `:63` `past_cap`, `bin/rule_hook/round_cap.py:10` and `bin/larv_review/reviewer_header.py:73`: the round cap lives in five places, and SKILL.md's Done, Cap, Re-entry and Mechanical answers point at each other as prose.
|
||||
- Locality: `bin/loop_claude/loop/chunk_windows.py:107` `start_chunks`: under one flock it checks the session's owner, splits running from stopped windows, computes the room, reads the plan with a fallback, gathers held items and filters again, with the limit applied a second time in `may_start`.
|
||||
- Shape, Locality: `bin/release_plan/ranking.py:239` `score`, `:144` `weigh` and `:250` `weight_of`: every function forks on `SHAPE` versus `OLD_SHAPE`, and one Score depends on five inputs held in other files.
|
||||
- Locality, Shape: `bin/plan_store/stores.py:1` and `bin/release_plan/todo_table.py:1`: `release_plan` and `plan_store` import each other, the plan has three names, and the goals file sits under `release_plan`.
|
||||
- Shape: `bin/larv_review/plan.py:22` `scoring_run_due`, with `owed.py`, `unmeasured.py` and `scoring.py`: the scoring-run trigger is spread over four modules, three of whose names don't say it, in a flat 14-module package that mixes rounds, the comprehension check and its triggers.
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:22` `INTERRUPT_RULES`, with `:197` `quotes_checked`: the judge's behaviour is held partly in prompt text and field metadata and partly in Python checks.
|
||||
- Shape: `bin/plan_store/jira_epic.py:356` `revision_of`: indexes the untyped tuple `scores` at `:530` returns by position.
|
||||
- Shape: `bin/agent_cycle/run.py:55` `Cycle.todo`, `bin/agent_cycle/hand_over.py:23` `hand_over` and `bin/release_plan/named_code.py:5`: names that say todo.md where the plan may be a Jira epic, a handover that is not the reload's, and a module with no code in it.
|
||||
- Navigation, Shape: `README.md:197` the `bin/` package list: 74 entries at one level, with the README's list as the only index.
|
||||
- Self-sufficiency: every seat names the decision-log titles that code cites for a reason (`routing.py:1`, `ranking.py:20`, `loop/routing_check.py:1`) as a cost; state each reason beside its constant and keep the citation as a footnote.
|
||||
|
||||
Scored L 4 because the refactor touches several components that hold known defects, E 2 because review and a manual check see a regression, I 3 because every session runs these tools. The chunk runs a scoring run, since it is a floor item.
|
||||
- Self-sufficiency, Locality: `bin/agent_cycle/routing.py:115` `unfinished_route`, with `:131` `escalated_route`: five rungs, a count and the escalation mark held at once. The module table resolves the what, but the why of the caps is only in the decision log. Every seat in both runs named it.
|
||||
- Self-sufficiency: `bin/agent_cycle/judge.py:235` `quotes_checked`, with `:23` `INTERRUPT_RULES` and `:76` `TASK_HEADING`: six quote kinds fail differently, the prompt is behaviour no code checks, and `TASK_HEADING` is silently an archive format. Seven seats named it.
|
||||
- Self-sufficiency: `bin/rule_hook/rules.py:27` `RULES`: each rule's only specification is one long English sentence, such as `env-file-read`, and its check lives in a sibling module that nothing ties it to. Five seats named it.
|
||||
- Self-sufficiency, Locality: `skills/larv-review/SKILL.md:89` "Round cap" and `:97` "Re-entry", with `bin/review_rules/review_passes.py:8` `PASS_AGENTS`: rules with exceptions to exceptions, a cap spread over three packages and this prose, and code constants that must match sentences here.
|
||||
- Locality: `bin/do_epic/main.py:283` `parked_through`: a polling loop with four mutable locals across three result types, and a crash-ordering invariant across a state file, a window name and Jira. Five seats named it; two would least want to change it.
|
||||
- Locality: `bin/do_epic/scheduler.py:136` `start_chunks`, with `bin/loop_claude/loop/chunk_windows.py:107` `may_start`: overlapping window sets from two stores feed an elif chain under nested flocks, with the tmux state's schema in `agent_cycle/tmux.py:92` `as_listed`.
|
||||
- Locality: `bin/chunk_pr/main.py:429` `levelled_and_finished`: a load-bearing order held together by one-liners where a Failure's truthiness carries the control flow.
|
||||
- Locality, Shape: `bin/agent_cycle/run.py:150` `rule`, with `:32` `Cycle` and `:240` `close`: a 16-field value, very long single-line expressions, and an archive-before-step-up order that only reading order tells.
|
||||
- Locality: `bin/do_epic/main.py:11` imports, with `bin/loop_claude/loop/reload.py:18` `LoopRun`: do_epic reaches into eight loop_claude modules over a wire format a renamed field breaks.
|
||||
- Shape, Navigation: `bin/agent_cycle/verdicts.py:1`, `bin/loop_claude/cycle/` and `bin/loop_state/paths.py:6`: stale `cycle.` names, and folders whose names mislead.
|
||||
- Locality: `bin/project_config/settings.py:182` `load`: one list encodes the whole validation matrix.
|
||||
- Shape: `bin/agent_cycle/stuck_workers.py:52` `Watch.check`: the condition at line 59 mixes `or` and `and` without parentheses over dicts mutated across ticks.
|
||||
|
||||
### 264. Report the comprehension seats and the escalated subagents as subagent types of their own in `routing-figures.md`, with their dollars.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user