|
|
|
@@ -51,10 +51,10 @@ Give a reviewer without Bash the branch diff and `git ls-files`'s output in its
|
|
|
|
|
**Round cap.**
|
|
|
|
|
|
|
|
|
|
- **Round.** A round is one launch of a pass's reviewer: the first, each re-entry, and the rerun after the architect returns Stage 0 questions ("Architecture" below).
|
|
|
|
|
- **Architecture round.** The architecture pass's first round is the architect (unless skipped), the principles audit and the scoring run. A later round relaunches only the reviewers whose findings its fixes answer, or the whole round where the fixes fire the pass's trigger.
|
|
|
|
|
- **Architecture round.** The architecture pass's first round is the architect (unless skipped), the principles audit and the scoring run. A later round relaunches the scoring run and each reviewer whose 🔴 or 🟡 its fixes answer, or the whole round, the architect included, where the fixes fire the pass's trigger by more than shipping the release's last item.
|
|
|
|
|
- **Auto-reviewer.** The external auto-reviewer (§4) is a pass of its own, each review it posts a round.
|
|
|
|
|
- **Count.** Close each round with one commit that holds the round's fixes and is titled `Answer <pass> round <n>: …`, `<pass>` being the pass's name in lower case, such as `full scan`. A round that changed nothing gets an empty commit (`git commit --allow-empty`). Push the commits when §4 runs next, where there is a remote. A pass's count is the highest `<n>` among titles holding `Answer <pass> round <n>:` in `git log origin/<default branch>..HEAD` after a `git fetch`, or in `git log <default branch>..HEAD` with no remote. The auto-reviewer's count is the number of its reviews on the PR.
|
|
|
|
|
- **Later rounds.** From round 2, prompt an agent under `~/.claude/agents/` with the previous round's findings verbatim and what changed since: `git diff <the commit the previous round reviewed> HEAD`, since the fixes may be unpushed.
|
|
|
|
|
- **Later rounds.** From round 2, prompt an agent under `~/.claude/agents/` with its own last round's findings verbatim and what changed since: `git diff <the commit that round reviewed> HEAD`, since the fixes may be unpushed.
|
|
|
|
|
- **Done.** A pass is done when its latest round leaves no 🔴 or 🟡 standing: none was reported, or each was shown factually wrong, declined, filed, or named under the bar per "Findings". Resolve that round's 🟢s and ❓s per "Findings" too.
|
|
|
|
|
- **Cap.** A pass takes at most three rounds per chunk. Instead of a fourth, list what is open and ask the user. For the auto-reviewer, ask before the push that would summon its fourth, and hold the fixes unpushed until the answer.
|
|
|
|
|
- **Answer.** A yes grants that pass one more round, after which the ask repeats; a no leaves the PR unmerged.
|
|
|
|
@@ -81,7 +81,7 @@ Launch systems-architect: review the system as a whole entered through this chan
|
|
|
|
|
- **Stage 0 questions returned**: relay them to the user, record the answers in the README, re-run once.
|
|
|
|
|
- **BLOCK** → confirm with the user first when the restructure materially reshapes their PR; until confirmed, no later pass runs.
|
|
|
|
|
|
|
|
|
|
Then the principles audit, each auditor over the whole project: one principles-auditor for the README's goals, and one per file in `~/.claude/principles/` whose `Applies to` line the project meets, judged from the README and `git ls-files`. Unsure → launch it. Name each file left out, and why, in the summary.
|
|
|
|
|
Then the principles audit, each auditor over the whole project: one principles-auditor for the README's goals, and one per file in `~/.claude/principles/` whose `Applies to` line the project meets, judged from the README, `git ls-files` and the branch diff. A file without the line applies to every project. Unsure → launch it.
|
|
|
|
|
|
|
|
|
|
Then the comprehension floor, which the scoring run measures. Four simulated readers — Junior A, Mid A, the maintainability senior and the inherited architect — each read the whole project, not the diff, and score it from 1 to 10 overall and on four dimensions: Navigation, Locality, Shape and Self-sufficiency. A seat's overall may not exceed its lowest dimension by more than 1. Each score is the mean of the four seats, to two decimals. Launch the seats per `~/.claude/skills/comprehension-panel/SKILL.md` → "The scoring run".
|
|
|
|
|
|
|
|
|
@@ -132,4 +132,4 @@ Launch prose-reviewer with what the diff touched and every section this review c
|
|
|
|
|
|
|
|
|
|
## 6. Wrap up
|
|
|
|
|
|
|
|
|
|
Summarize: PR URL and final state, every reviewer's verdict, rounds per pass, passes skipped, findings fixed vs answered vs declined vs open — each answer with what settles it, each decline with its reason, a 🟡's with the goal or technical principle it rests on — CI status, decisions recorded (file paths), `todo.md`/`CHANGELOG.md` updated, and any 🔀 escalation left for the user.
|
|
|
|
|
Summarize: PR URL and final state, every reviewer's verdict, rounds per pass, passes skipped, principles files left out with why, findings fixed vs answered vs declined vs open — each answer with what settles it, each decline with its reason, a 🟡's with the goal or technical principle it rests on — CI status, decisions recorded (file paths), `todo.md`/`CHANGELOG.md` updated, and any 🔀 escalation left for the user.
|
|
|
|
|