Bring nine lessons from a client setup into the principles, the reviewers, larv-review and the project config #618

Merged
lilleman merged 8 commits from item-429 into main 2026-11-18 20:40:58 +01:00
Owner

Nine lessons from running the setup in another repo:

  • larv-review opens the pull request after our own review where CI runs on pushed branches, and keeps the draft-first order elsewhere.
  • New principles: rules for tests on a shared environment, function inputs that cannot disagree, "Never mock a service your own team runs" and "Don't loosen a type when refactoring".
  • stability-reviewer checks a change that stores a value differently.
  • A coding-conventions setting in the project config lists the team's convention files; reviewer-header names them and every reviewer reads them.
  • larv-review files an item to add a mutation tool where mutate-changes covers none of a language.
  • Every finding of an outside reviewer changes the setup, a deterministic tool first.

A panel of three readers picked coding-conventions over the item's conventions, 2-1.

Nine lessons from running the setup in another repo: - larv-review opens the pull request after our own review where CI runs on pushed branches, and keeps the draft-first order elsewhere. - New principles: rules for tests on a shared environment, function inputs that cannot disagree, "Never mock a service your own team runs" and "Don't loosen a type when refactoring". - stability-reviewer checks a change that stores a value differently. - A `coding-conventions` setting in the project config lists the team's convention files; `reviewer-header` names them and every reviewer reads them. - larv-review files an item to add a mutation tool where `mutate-changes` covers none of a language. - Every finding of an outside reviewer changes the setup, a deterministic tool first. A panel of three readers picked `coding-conventions` over the item's `conventions`, 2-1.
lilleman added 1 commit 2026-11-18 20:19:27 +01:00
lilleman added 2 commits 2026-11-18 20:25:47 +01:00
lilleman marked the pull request as ready for review 2026-11-18 20:34:40 +01:00
lilleman added 4 commits 2026-11-18 20:34:41 +01:00
lilleman added 1 commit 2026-11-18 20:34:52 +01:00
Finish item 429 in the plan
CI / tests (pull_request) Successful in 3m35s
e113f02db1
lilleman merged commit e113f02db1 into main 2026-11-18 20:40:58 +01:00
lilleman deleted branch item-429 2026-11-18 20:40:58 +01:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lilleman/claude-config#618