File item 512: make stability-reviewer check that composed lookup keys cannot collide #686

Merged
lilleman merged 1 commits from item-512 into main 2026-11-21 13:34:16 +01:00
+9 -1
View File
@@ -6,7 +6,7 @@
`Bar = 0.1`
`Next ID = 512`
`Next ID = 513`
## Items
@@ -18,6 +18,7 @@
| 505 | 0.16.0 | 504 | owner | **Bench adding source data in `task-bench`: hand Haiku a fake register that a seeded script generates for a made-up country, and check the importer, the data and the licence entry it adds, starting with five tasks for fejkdata.** | 3 | 2 | 1 | 4 | 5 | 1.1 by 3, code health by 2 | 2.6 |
| 508 | 0.16.0 | | owner | **Plant bugs for `task-bench` in Python, Rust, TypeScript and PHP, from the mutants `mutate-changes` runs for each, so this repo benches itself.** | 3 | 2 | 1 | 4 | 5 | 1.1 by 3, code health by 2 | 2.6 |
| 506 | 0.16.0 | 504 | owner | **Go over the bench features in each release review: reapply each reference patch, drop a feature that no longer breaks a goal, and add features until they cover the places the seats find hardest.** | 2 | 2 | 2 | 4 | 3 | 1.1 by 3 | 1.1 |
| 512 | 0.16.0 | | | **Make stability-reviewer check that keys built from path segments, or matched by prefix, cannot collide.** | 1 | 2 | 2 | 3 | 1 | 1.1 by 2 | 0.9 |
| 507 | 0.16.0 | 504 | owner | **Bench rebuilding a feature the project shipped: revert its commit at the head, hand Haiku its item tagline, and check with the tests that commit added.** | 3 | 2 | 1 | 4 | 5 | 1.1 by 3 | 0.7 |
| 477 | 0.17.0 | | question | **Rewrite `## Goals` and `## Audience` for a setup others install and run apart from their own `~/.claude`.** | 1 | 1 | 2 | 2 | 2 | | 0.0 |
| 478 | 0.17.0 | | question | **Name the project, its repo and its two commands, today proposed as `do-release` and `do-epic`.** | 1 | 1 | 2 | 2 | 1 | | 0.0 |
@@ -151,6 +152,13 @@ Each tool reports a killed mutant by file and line, and some by column; the plan
A reference patch that no longer applies is rewritten by the review's model. A feature whose goal changed may have become real work, so it goes. New features follow item 504's rule: plausible for another audience, against one of this project's goals.
### 512. Make stability-reviewer check that keys built from path segments, or matched by prefix, cannot collide.
An outside reviewer found two bugs in one chunk that our stability round passed. Both were lookups keyed by a path built from segments or matched by prefix, where two inputs give one key: a linked table that has a column of its own name took the column's row, and two modules whose namespaces nest (`ns` and `ns.sub`) were credited to the first prefix. Add a bullet beside the separator bullet in `agents/stability-reviewer.md` §5: where the change builds a lookup key by joining segments, or matches one by prefix, look for two inputs that give one key, such as a segment equal to its parent's name or a namespace that is a dot-prefix of another, and report the input the lookup credits to the wrong entry.
Touches:
- `agents/stability-reviewer.md`: `### 5. Edge Cases & Input Validation` (small)
### 507. Bench rebuilding a feature the project shipped: revert its commit at the head, hand Haiku its item tagline, and check with the tests that commit added.
Such tasks cost nothing to write and are realistic. A commit whose revert doesn't apply cleanly at both the base and the head is skipped.